You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by fp...@apache.org on 2012/12/10 10:58:19 UTC
svn commit: r1419306 - in /zookeeper/bookkeeper/trunk: CHANGES.txt
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java
Author: fpj
Date: Mon Dec 10 09:58:19 2012
New Revision: 1419306
URL: http://svn.apache.org/viewvc?rev=1419306&view=rev
Log:
BOOKKEEPER-469: Remove System.out.println from TestLedgerManager (ivank via fpj)
Modified:
zookeeper/bookkeeper/trunk/CHANGES.txt
zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java
Modified: zookeeper/bookkeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/CHANGES.txt?rev=1419306&r1=1419305&r2=1419306&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/CHANGES.txt (original)
+++ zookeeper/bookkeeper/trunk/CHANGES.txt Mon Dec 10 09:58:19 2012
@@ -226,6 +226,8 @@ Trunk (unreleased changes)
BOOKKEEPER-204: Provide a MetaStore interface, and a mock implementation. (Jiannan Wang via ivank)
+ BOOKKEEPER-469: Remove System.out.println from TestLedgerManager (ivank via fpj)
+
hedwig-server:
BOOKKEEPER-250: Need a ledger manager like interface to manage metadata operations in Hedwig (sijie via ivank)
Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java?rev=1419306&r1=1419305&r2=1419306&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java Mon Dec 10 09:58:19 2012
@@ -86,6 +86,7 @@ public class TestLedgerManager extends B
LedgerManagerFactory.newLedgerManagerFactory(conf, zkc);
fail("Shouldn't reach here");
} catch (Exception e) {
+ LOG.error("Received exception", e);
assertTrue("Invalid exception",
e.getMessage().contains("does not match existing layout"));
}
@@ -101,6 +102,7 @@ public class TestLedgerManager extends B
LedgerManagerFactory f = LedgerManagerFactory.newLedgerManagerFactory(conf, zkc);
fail("Shouldn't reach here");
} catch (Exception e) {
+ LOG.error("Received exception", e);
assertTrue("Invalid exception",
e.getMessage().contains("Failed to get ledger manager factory class from configuration"));
}
@@ -141,6 +143,7 @@ public class TestLedgerManager extends B
LedgerManagerFactory.newLedgerManagerFactory(conf, zkc);
fail("Shouldn't reach here");
} catch (Exception e) {
+ LOG.error("Received exception", e);
assertTrue("Invalid exception",
e.getMessage().contains("does not match existing layout"));
}
@@ -166,6 +169,7 @@ public class TestLedgerManager extends B
LedgerManagerFactory.newLedgerManagerFactory(conf, zkc);
fail("Shouldn't reach here");
} catch (Exception e) {
+ LOG.error("Received exception", e);
assertTrue("Invalid exception",
e.getMessage().contains("Failed to instantiate ledger manager factory"));
}
@@ -183,7 +187,7 @@ public class TestLedgerManager extends B
LedgerManagerFactory.newLedgerManagerFactory(conf, zkc);
fail("Shouldn't reach here");
} catch (Exception e) {
- System.out.println(e.getMessage());
+ LOG.error("Received exception", e);
assertTrue("Invalid exception",
e.getMessage().contains("Incompatible layout version found"));
}