You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Tomoko Uchida <to...@gmail.com> on 2020/10/19 14:20:06 UTC
Automatically delete merged branches (by Github)?
Hi,
it seems there are many active branches that are already merged into master
via Github PR.
Github has a configuration to automatically delete the branch when a PR is
merged (Settings -> Options -> "Automatically delete head branches") but I
think it is disabled by default.
I cannot change the settings of lucene-solr repo, but I wonder if there is
someone who has the authority to change the setting. Now many of us already
use github, so would it be good to let github delete obsolete branches
instead of manually doing so?
Tomoko
Re: Automatically delete merged branches (by Github)?
Posted by Tomoko Uchida <to...@gmail.com>.
I deleted all "merged" branches.
I'd agree that it's a good custom to push feature branches into forked
local repos, not the master repo (unless it's really necessary).
For the moment, please check branches you created and delete obsolete ones.
https://github.com/apache/lucene-solr/branches/all
Tomoko
2020年10月20日(火) 3:30 Alexandre Rafalovitch <ar...@gmail.com>:
> On Mon, 19 Oct 2020 at 14:24, Uwe Schindler <uw...@thetaphi.de> wrote:
>
>> Nice possibility on top: You can force push as often as you like! ☕🤣
>>
>
> Up until the point you create a PR. After that, I think it gets confused
> and doubles the entries. Unless I messed up one of my PRs even worse than I
> thought.
>
> +1 on doing changes in the personal fork of the repo.
>
> Regards,
> Alex.
>
Re: Automatically delete merged branches (by Github)?
Posted by Alexandre Rafalovitch <ar...@gmail.com>.
On Mon, 19 Oct 2020 at 14:24, Uwe Schindler <uw...@thetaphi.de> wrote:
> Nice possibility on top: You can force push as often as you like! ☕🤣
>
Up until the point you create a PR. After that, I think it gets confused
and doubles the entries. Unless I messed up one of my PRs even worse than I
thought.
+1 on doing changes in the personal fork of the repo.
Regards,
Alex.
Re: Automatically delete merged branches (by Github)?
Posted by Uwe Schindler <uw...@thetaphi.de>.
Nice possibility on top: You can force push as often as you like! ☕🤣
Am October 19, 2020 6:18:59 PM UTC schrieb Erick Erickson <er...@gmail.com>:
>+1, this is what I’ve been doing for a while, and it gives me a warm
>fuzzy feeling to know that no mater what, until the final merge into
>the master repo I can’t inadvertently screw up said master repo….
>
>
>> On Oct 19, 2020, at 1:53 PM, David Smiley <ds...@apache.org> wrote:
>>
>> +100 to Uwe's total message -- my thoughts exactly. When I first
>started using GitHub, I had an SVN mindset and didn't recognize the
>point of repo forks. Now I can clearly see that it allows for PRs that
>don't pollute the branches in the master repo.
>>
>> On Mon, Oct 19, 2020 at 1:01 PM Uwe Schindler <uw...@thetaphi.de>
>wrote:
>> Hi Tomoko,
>>
>> IMHO, people should open PRs using a branch on their own GitHub fork.
>It also works well when you work together. Any ASF org member on GitHub
>can automatically commit and push to private branches of outside users,
>as GitHub enforces you to allow pushes from members of the org the PR
>is opened on.
>>
>> So maybe only create branches on ASF server if it's useful for all
>(big issue and long development time, like Gradle switch).
>>
>> Uwe
>>
>> Am October 19, 2020 4:45:23 PM UTC schrieb Tomoko Uchida
><to...@gmail.com>:
>> Thank you Jan for the pointer.
>> I read the Infra wiki, and checked the yaml files in several major
>ASF repositories (e.g. Hadoop, Flink, Kafka, AIrflow, ...). It looks
>like there is no such configuration for the feature.
>>
>> If it's ok I will delete all branches that have been already merged.
>> Also I'd suggest deleting branches after merging them into the master
>(if you open a PR, you can find a bit obscure button to "delete" the
>branch which is related to the PR).
>>
>> Tomoko
>>
>>
>> 2020年10月20日(火) 0:19 Jan Høydahl <ja...@cominvent.com>:
>> Check the .asf.yml file in our repo and
>https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
>
>> That’s where we control github features… But I cannot see that
>option.
>>
>> Jan
>>
>> > 19. okt. 2020 kl. 16:20 skrev Tomoko Uchida
><to...@gmail.com>:
>> >
>> > Hi,
>> > it seems there are many active branches that are already merged
>into master via Github PR.
>> >
>> > Github has a configuration to automatically delete the branch when
>a PR is merged (Settings -> Options -> "Automatically delete head
>branches") but I think it is disabled by default.
>> > I cannot change the settings of lucene-solr repo, but I wonder if
>there is someone who has the authority to change the setting. Now many
>of us already use github, so would it be good to let github delete
>obsolete branches instead of manually doing so?
>> >
>> > Tomoko
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
>> --
>> Uwe Schindler
>> Achterdiek 19, 28357 Bremen
>> https://www.thetaphi.de
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>For additional commands, e-mail: dev-help@lucene.apache.org
--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de
Re: Automatically delete merged branches (by Github)?
Posted by Erick Erickson <er...@gmail.com>.
+1, this is what I’ve been doing for a while, and it gives me a warm fuzzy feeling to know that no mater what, until the final merge into the master repo I can’t inadvertently screw up said master repo….
> On Oct 19, 2020, at 1:53 PM, David Smiley <ds...@apache.org> wrote:
>
> +100 to Uwe's total message -- my thoughts exactly. When I first started using GitHub, I had an SVN mindset and didn't recognize the point of repo forks. Now I can clearly see that it allows for PRs that don't pollute the branches in the master repo.
>
> On Mon, Oct 19, 2020 at 1:01 PM Uwe Schindler <uw...@thetaphi.de> wrote:
> Hi Tomoko,
>
> IMHO, people should open PRs using a branch on their own GitHub fork. It also works well when you work together. Any ASF org member on GitHub can automatically commit and push to private branches of outside users, as GitHub enforces you to allow pushes from members of the org the PR is opened on.
>
> So maybe only create branches on ASF server if it's useful for all (big issue and long development time, like Gradle switch).
>
> Uwe
>
> Am October 19, 2020 4:45:23 PM UTC schrieb Tomoko Uchida <to...@gmail.com>:
> Thank you Jan for the pointer.
> I read the Infra wiki, and checked the yaml files in several major ASF repositories (e.g. Hadoop, Flink, Kafka, AIrflow, ...). It looks like there is no such configuration for the feature.
>
> If it's ok I will delete all branches that have been already merged.
> Also I'd suggest deleting branches after merging them into the master (if you open a PR, you can find a bit obscure button to "delete" the branch which is related to the PR).
>
> Tomoko
>
>
> 2020年10月20日(火) 0:19 Jan Høydahl <ja...@cominvent.com>:
> Check the .asf.yml file in our repo and https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
> That’s where we control github features… But I cannot see that option.
>
> Jan
>
> > 19. okt. 2020 kl. 16:20 skrev Tomoko Uchida <to...@gmail.com>:
> >
> > Hi,
> > it seems there are many active branches that are already merged into master via Github PR.
> >
> > Github has a configuration to automatically delete the branch when a PR is merged (Settings -> Options -> "Automatically delete head branches") but I think it is disabled by default.
> > I cannot change the settings of lucene-solr repo, but I wonder if there is someone who has the authority to change the setting. Now many of us already use github, so would it be good to let github delete obsolete branches instead of manually doing so?
> >
> > Tomoko
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
> --
> Uwe Schindler
> Achterdiek 19, 28357 Bremen
> https://www.thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Automatically delete merged branches (by Github)?
Posted by David Smiley <ds...@apache.org>.
+100 to Uwe's total message -- my thoughts exactly. When I first started
using GitHub, I had an SVN mindset and didn't recognize the point of repo
forks. Now I can clearly see that it allows for PRs that don't pollute the
branches in the master repo.
On Mon, Oct 19, 2020 at 1:01 PM Uwe Schindler <uw...@thetaphi.de> wrote:
> Hi Tomoko,
>
> IMHO, people should open PRs using a branch on their own GitHub fork. It
> also works well when you work together. Any ASF org member on GitHub can
> automatically commit and push to private branches of outside users, as
> GitHub enforces you to allow pushes from members of the org the PR is
> opened on.
>
> So maybe only create branches on ASF server if it's useful for all (big
> issue and long development time, like Gradle switch).
>
> Uwe
>
> Am October 19, 2020 4:45:23 PM UTC schrieb Tomoko Uchida <
> tomoko.uchida.1111@gmail.com>:
>>
>> Thank you Jan for the pointer.
>> I read the Infra wiki, and checked the yaml files in several major ASF
>> repositories (e.g. Hadoop, Flink, Kafka, AIrflow, ...). It looks like there
>> is no such configuration for the feature.
>>
>> If it's ok I will delete all branches that have been already merged.
>> Also I'd suggest deleting branches after merging them into the master (if
>> you open a PR, you can find a bit obscure button to "delete" the branch
>> which is related to the PR).
>>
>> Tomoko
>>
>>
>> 2020年10月20日(火) 0:19 Jan Høydahl <ja...@cominvent.com>:
>>
>>> Check the .asf.yml file in our repo and
>>> https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
>>> That’s where we control github features… But I cannot see that option.
>>>
>>> Jan
>>>
>>> > 19. okt. 2020 kl. 16:20 skrev Tomoko Uchida <
>>> tomoko.uchida.1111@gmail.com>:
>>> >
>>> > Hi,
>>> > it seems there are many active branches that are already merged into
>>> master via Github PR.
>>> >
>>> > Github has a configuration to automatically delete the branch when a
>>> PR is merged (Settings -> Options -> "Automatically delete head branches")
>>> but I think it is disabled by default.
>>> > I cannot change the settings of lucene-solr repo, but I wonder if
>>> there is someone who has the authority to change the setting. Now many of
>>> us already use github, so would it be good to let github delete obsolete
>>> branches instead of manually doing so?
>>> >
>>> > Tomoko
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
> --
> Uwe Schindler
> Achterdiek 19, 28357 Bremen
> https://www.thetaphi.de
>
Re: Automatically delete merged branches (by Github)?
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi Tomoko,
IMHO, people should open PRs using a branch on their own GitHub fork. It also works well when you work together. Any ASF org member on GitHub can automatically commit and push to private branches of outside users, as GitHub enforces you to allow pushes from members of the org the PR is opened on.
So maybe only create branches on ASF server if it's useful for all (big issue and long development time, like Gradle switch).
Uwe
Am October 19, 2020 4:45:23 PM UTC schrieb Tomoko Uchida <to...@gmail.com>:
>Thank you Jan for the pointer.
>I read the Infra wiki, and checked the yaml files in several major ASF
>repositories (e.g. Hadoop, Flink, Kafka, AIrflow, ...). It looks like
>there
>is no such configuration for the feature.
>
>If it's ok I will delete all branches that have been already merged.
>Also I'd suggest deleting branches after merging them into the master
>(if
>you open a PR, you can find a bit obscure button to "delete" the branch
>which is related to the PR).
>
>Tomoko
>
>
>2020年10月20日(火) 0:19 Jan Høydahl <ja...@cominvent.com>:
>
>> Check the .asf.yml file in our repo and
>>
>https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
>> That’s where we control github features… But I cannot see that
>option.
>>
>> Jan
>>
>> > 19. okt. 2020 kl. 16:20 skrev Tomoko Uchida <
>> tomoko.uchida.1111@gmail.com>:
>> >
>> > Hi,
>> > it seems there are many active branches that are already merged
>into
>> master via Github PR.
>> >
>> > Github has a configuration to automatically delete the branch when
>a PR
>> is merged (Settings -> Options -> "Automatically delete head
>branches") but
>> I think it is disabled by default.
>> > I cannot change the settings of lucene-solr repo, but I wonder if
>there
>> is someone who has the authority to change the setting. Now many of
>us
>> already use github, so would it be good to let github delete obsolete
>> branches instead of manually doing so?
>> >
>> > Tomoko
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de
Re: Automatically delete merged branches (by Github)?
Posted by Tomoko Uchida <to...@gmail.com>.
Thank you Jan for the pointer.
I read the Infra wiki, and checked the yaml files in several major ASF
repositories (e.g. Hadoop, Flink, Kafka, AIrflow, ...). It looks like there
is no such configuration for the feature.
If it's ok I will delete all branches that have been already merged.
Also I'd suggest deleting branches after merging them into the master (if
you open a PR, you can find a bit obscure button to "delete" the branch
which is related to the PR).
Tomoko
2020年10月20日(火) 0:19 Jan Høydahl <ja...@cominvent.com>:
> Check the .asf.yml file in our repo and
> https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
> That’s where we control github features… But I cannot see that option.
>
> Jan
>
> > 19. okt. 2020 kl. 16:20 skrev Tomoko Uchida <
> tomoko.uchida.1111@gmail.com>:
> >
> > Hi,
> > it seems there are many active branches that are already merged into
> master via Github PR.
> >
> > Github has a configuration to automatically delete the branch when a PR
> is merged (Settings -> Options -> "Automatically delete head branches") but
> I think it is disabled by default.
> > I cannot change the settings of lucene-solr repo, but I wonder if there
> is someone who has the authority to change the setting. Now many of us
> already use github, so would it be good to let github delete obsolete
> branches instead of manually doing so?
> >
> > Tomoko
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Automatically delete merged branches (by Github)?
Posted by Jan Høydahl <ja...@cominvent.com>.
Check the .asf.yml file in our repo and https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
That’s where we control github features… But I cannot see that option.
Jan
> 19. okt. 2020 kl. 16:20 skrev Tomoko Uchida <to...@gmail.com>:
>
> Hi,
> it seems there are many active branches that are already merged into master via Github PR.
>
> Github has a configuration to automatically delete the branch when a PR is merged (Settings -> Options -> "Automatically delete head branches") but I think it is disabled by default.
> I cannot change the settings of lucene-solr repo, but I wonder if there is someone who has the authority to change the setting. Now many of us already use github, so would it be good to let github delete obsolete branches instead of manually doing so?
>
> Tomoko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org