You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/05/09 21:01:04 UTC
[GitHub] [ratis] adoroszlai opened a new pull request, #644: RATIS-1579. Verify build from source release tarball in CI
adoroszlai opened a new pull request, #644:
URL: https://github.com/apache/ratis/pull/644
## What changes were proposed in this pull request?
CI should ensure that source tarball contents can be compiled (see RATIS-1576 for example where it was broken).
This PR includes the following changes:
* _build_ check produces tarballs and store the one with sources
* _compile_ check builds from the source tarball instead of git repo
* source tarball sets `+x` permission on `dev-support` scripts
https://issues.apache.org/jira/browse/RATIS-1579
## How was this patch tested?
https://github.com/adoroszlai/incubator-ratis/actions/runs/2296722458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #644: RATIS-1579. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #644:
URL: https://github.com/apache/ratis/pull/644#issuecomment-1121940958
@adoroszlai , I understand that it needs extra works to fix problem like RATIS-1576. Sorry. Does it worth to build a release for every commit since it will take some time? Is it possible to run such check only when there are changes in pom.xml files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai commented on pull request #644: RATIS-1579. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #644:
URL: https://github.com/apache/ratis/pull/644#issuecomment-1125899796
Thanks @szetszwo for reviewing and committing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #644: RATIS-1579. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #644:
URL: https://github.com/apache/ratis/pull/644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] adoroszlai commented on pull request #644: RATIS-1579. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #644:
URL: https://github.com/apache/ratis/pull/644#issuecomment-1122044025
@szetszwo Ozone CI has selective checks to save time. We can implement similar feature for Ratis CI. However, Ratis is a much smaller project, so the possible time savings are also less. In this specific case the extra _build_ check adds only 1 minute. Since _unit_ checks are the slowest (8-10 minutes), and (_build_, _compile_) sequence runs in parallel with _unit_, the wall clock time for a complete CI workflow does not increase with this change:
before: https://github.com/apache/ratis/actions/runs/2289650001
after: https://github.com/apache/ratis/actions/runs/2296786825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #644: RATIS-1579. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #644:
URL: https://github.com/apache/ratis/pull/644#issuecomment-1122051042
> ... the wall clock time for a complete CI workflow does not increase with this change ...
That's great! Let's do it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org