You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/01/09 12:00:55 UTC
[PR] [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema` [spark]
zhengruifeng opened a new pull request, #53750:
URL: https://github.com/apache/spark/pull/53750
### What changes were proposed in this pull request?
Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema`
### Why are the changes needed?
to make the roundtrip `from_arrow_type(to_arrow_type(...))` `from_arrow_schema(to_arrow_schema(...))` work for all datatype with default value
### Does this PR introduce _any_ user-facing change?
no, the two functions are only used internally
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53750:
URL: https://github.com/apache/spark/pull/53750#issuecomment-3728626682
## JIRA Issue Information
=== Improvement SPARK-54987 ===
Summary: Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema`
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #53750:
URL: https://github.com/apache/spark/pull/53750#issuecomment-3736570191
> Is this going to be a breaking change?
@gaogaotiantian No, it is an internal function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #53750:
URL: https://github.com/apache/spark/pull/53750#issuecomment-3737090683
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema` [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #53750:
URL: https://github.com/apache/spark/pull/53750#issuecomment-3730116515
Is this going to be a breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #53750: [SPARK-54987][PYTHON] Change the default value of prefer_timestamp_ntz to True in `from_arrow_type/from_arrow_schema`
URL: https://github.com/apache/spark/pull/53750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org