You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/13 04:05:04 UTC
[GitHub] [incubator-shardingsphere] dongzl opened a new issue #5159:
Optimizate code about sharding-orchestration-center-etcd module.
dongzl opened a new issue #5159: Optimizate code about sharding-orchestration-center-etcd module.
URL: https://github.com/apache/incubator-shardingsphere/issues/5159
I find some code about `sharding-orchestration-center-etcd` can be optimizated.
- [ ] `guava.version` in this module's pom.xml is unused, I think it can be removed.
- [ ] `jetcd.version` in this module's pom.xml can be moved to project root pom.xml.
- [ ] upgrade `jetcd.version` to newest version.
- [ ] In `EtcdCenterRepository` file, `config` is a global variable, but it is not used except the `init` method, I think we can define a local variable at `init` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #5159:
Optimizate code about sharding-orchestration-center-etcd module.
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5159: Optimizate code about sharding-orchestration-center-etcd module.
URL: https://github.com/apache/incubator-shardingsphere/issues/5159#issuecomment-612762274
Awesome.
Accept 2/3/4.
The no.2: Guava version here is greater than root for jetcd. Removing is unneccessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl edited a comment on issue #5159:
Optimizate code about sharding-orchestration-center-etcd module.
Posted by GitBox <gi...@apache.org>.
dongzl edited a comment on issue #5159: Optimizate code about sharding-orchestration-center-etcd module.
URL: https://github.com/apache/incubator-shardingsphere/issues/5159#issuecomment-612768652
> Awesome.
>
> Accept 2/4.
> The no.2: Guava version here is greater than root for jetcd. Removing is unneccessary.
> The no.3: We should test compatiblity first.
Hi @kimmking , OK, I will fix this issue and test it to work well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #5159:
Optimizate code about sharding-orchestration-center-etcd module.
Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #5159: Optimizate code about sharding-orchestration-center-etcd module.
URL: https://github.com/apache/incubator-shardingsphere/issues/5159#issuecomment-612768652
> unneccessary
Hi @kimmking , OK, I will fix this issue and test it to work well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue
#5159: Optimizate code about sharding-orchestration-center-etcd module.
Posted by GitBox <gi...@apache.org>.
kimmking edited a comment on issue #5159: Optimizate code about sharding-orchestration-center-etcd module.
URL: https://github.com/apache/incubator-shardingsphere/issues/5159#issuecomment-612762274
Awesome.
Accept 2/4.
The no.2: Guava version here is greater than root for jetcd. Removing is unneccessary.
The no.3: We should test compatiblity first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking edited a comment on issue
#5159: Optimizate code about sharding-orchestration-center-etcd module.
Posted by GitBox <gi...@apache.org>.
kimmking edited a comment on issue #5159: Optimizate code about sharding-orchestration-center-etcd module.
URL: https://github.com/apache/incubator-shardingsphere/issues/5159#issuecomment-612762274
Awesome.
Accept 2/4.
The no.1: Guava version here is greater than root for jetcd. Removing is unneccessary.
The no.3: We should test compatiblity first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services