You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/31 04:29:12 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #4486: [Bug] Fix bug of load error hub and schema change
morningman opened a new pull request #4486:
URL: https://github.com/apache/incubator-doris/pull/4486
## Proposed changes
1. When WITH_MYSQL is off, load error hub does not suport MySQL load error hub,
we should check its return value. (introduced by #4371 )
2. misjudge the return value of `change_row_block` in schema_change.cpp (Introduced by #4388 )
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4486: [Bug] Fix bug of load error hub and schema change
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4486:
URL: https://github.com/apache/incubator-doris/pull/4486#discussion_r479883259
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1197,10 +1197,9 @@ OLAPStatus SchemaChangeWithSorting::process(RowsetReaderSharedPtr rowset_reader,
}
uint64_t filtered_rows = 0;
- if (!_row_block_changer.change_row_block(ref_row_block, rowset_reader->version().second,
- new_row_block, &filtered_rows)) {
+ if ((res = _row_block_changer.change_row_block(ref_row_block, rowset_reader->version().second,
+ new_row_block, &filtered_rows)) != OLAP_SUCCESS) {
Review comment:
It is better not to assign values in if statements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4486: [Bug] Fix bug of load error hub and schema change
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4486:
URL: https://github.com/apache/incubator-doris/pull/4486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4486: [Bug] Fix bug of load error hub and schema change
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4486:
URL: https://github.com/apache/incubator-doris/pull/4486#discussion_r479935323
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1197,10 +1197,9 @@ OLAPStatus SchemaChangeWithSorting::process(RowsetReaderSharedPtr rowset_reader,
}
uint64_t filtered_rows = 0;
- if (!_row_block_changer.change_row_block(ref_row_block, rowset_reader->version().second,
- new_row_block, &filtered_rows)) {
+ if ((res = _row_block_changer.change_row_block(ref_row_block, rowset_reader->version().second,
+ new_row_block, &filtered_rows)) != OLAP_SUCCESS) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org