You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2026/01/06 12:22:37 UTC

Re: [PR] GH-48452: [Python] Add tests for Date32 and Date64 array creation with masks [arrow]

AlenkaF commented on code in PR #48453:
URL: https://github.com/apache/arrow/pull/48453#discussion_r2664753302


##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -3278,14 +3278,28 @@ def test_error_sparse(self):
 
 
 def test_safe_cast_from_float_with_nans_to_int():
-    # TODO(kszucs): write tests for creating Date32 and Date64 arrays, see

Review Comment:
   Thanks! I think the current state is the closest I can think of getting to the TODO in question. Though the test do not fit into `test_pandas.py` anymore 😊 What do you think of moving them to `test_array.py`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org