You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2018/02/05 14:08:37 UTC

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9211


Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................

IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

The alias and ordinal substitution logic has been
changed by IMPALA-5191. This commit updates the
documentation regarding to the new behavior.

Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Cherry-picks: not for 2.x.
---
M docs/shared/impala_common.xml
M docs/topics/impala_aliases.xml
2 files changed, 77 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9211/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/211/


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Mar 2018 01:00:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, John Russell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9211

to look at the new patch set (#2).

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................

IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

The alias and ordinal substitution logic has been
changed by IMPALA-5191. This commit updates the
documentation regarding to the new behavior.

Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Cherry-picks: not for 2.x.
---
M docs/shared/impala_common.xml
M docs/topics/impala_aliases.xml
2 files changed, 77 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9211/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Mar 2018 01:04:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Mar 2018 00:59:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 03:43:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 1:

Looping in Alex for her information, because changes like this will require additional updates in downstream-only docs too.


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Feb 2018 17:56:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 1:

(1 comment)

thanks!

http://gerrit.cloudera.org:8080/#/c/9211/1/docs/topics/impala_aliases.xml
File docs/topics/impala_aliases.xml:

http://gerrit.cloudera.org:8080/#/c/9211/1/docs/topics/impala_aliases.xml@76
PS1, Line 76: , you can read more about it at
> Replace with "." Conref will render the text here.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Mar 2018 19:05:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 3:

(4 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@664
PS3, Line 664:       </codeph>, and <codeph>ORDER BY</codeph> clauses. This means that from version 3.0 Impala doesn't allow
> I think we should mention that we made this change to be more standard-conf
Thanks, that does sound better.


http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@698
PS3, Line 698:       You can also refer to the columns by their ordinals in the <codeph>SELECT</codeph> clause. Impala
> You can also refer to SELECT-list items by their ordinal position.
Done


http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@700
PS3, Line 700:       </codeph> clauses. However, from Impala 3.0, ordinals can only be used at the top level. For
> remove howeber
Done


http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@701
PS3, Line 701:       example, the followings are allowed:
> the following statements are allowed
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Mar 2018 00:55:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................

IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

The alias and ordinal substitution logic has been
changed by IMPALA-5191. This commit updates the
documentation regarding to the new behavior.

Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Cherry-picks: not for 2.x.
Reviewed-on: http://gerrit.cloudera.org:8080/9211
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_aliases.xml
2 files changed, 78 insertions(+), 1 deletion(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, John Russell, Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9211

to look at the new patch set (#4).

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................

IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

The alias and ordinal substitution logic has been
changed by IMPALA-5191. This commit updates the
documentation regarding to the new behavior.

Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Cherry-picks: not for 2.x.
---
M docs/shared/impala_common.xml
M docs/topics/impala_aliases.xml
2 files changed, 78 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/9211/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@664
PS3, Line 664:       </codeph>, and <codeph>ORDER BY</codeph> clauses. This means that from version 3.0 Impala doesn't allow
I think we should mention that we made this change to be more standard-conforming and consistent with other SQL DBMS.

There's also some duplication in words that can be improved, here's a slightly modified version to consider:

From Impala 3.0, the alias substitution logic in the GROUP BY, HAVING, and ORDER BY CLAUSES has become more consistent with standard SQL behavior, as follows. Aliases are now only legal at the top level, and not in subexpressions. The following statements are allowed:


http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@698
PS3, Line 698:       You can also refer to the columns by their ordinals in the <codeph>SELECT</codeph> clause. Impala
You can also refer to SELECT-list items by their ordinal position.


http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@700
PS3, Line 700:       </codeph> clauses. However, from Impala 3.0, ordinals can only be used at the top level. For
remove howeber


http://gerrit.cloudera.org:8080/#/c/9211/3/docs/shared/impala_common.xml@701
PS3, Line 701:       example, the followings are allowed:
the following statements are allowed



-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Mar 2018 21:56:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9211/1/docs/topics/impala_aliases.xml
File docs/topics/impala_aliases.xml:

http://gerrit.cloudera.org:8080/#/c/9211/1/docs/topics/impala_aliases.xml@76
PS1, Line 76: , you can read more about it at
Replace with "." Conref will render the text here.



-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Mar 2018 01:44:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 1:

> Alex, did you have some time to look at this change?

The texts were fine. Let me build this locally and check the conref.


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Mar 2018 00:25:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 )

Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
......................................................................


Patch Set 1:

Alex, did you have some time to look at this change?


-- 
To view, visit http://gerrit.cloudera.org:8080/9211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Mar 2018 00:19:25 +0000
Gerrit-HasComments: No