You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2017/06/24 09:14:36 UTC
spark git commit: [SPARK-21189][INFRA] Handle unknown error codes in
Jenkins rather then leaving incomplete comment in PRs
Repository: spark
Updated Branches:
refs/heads/master bfd73a7c4 -> 7c7bc8fc0
[SPARK-21189][INFRA] Handle unknown error codes in Jenkins rather then leaving incomplete comment in PRs
## What changes were proposed in this pull request?
Recently, Jenkins tests were unstable due to unknown reasons as below:
```
/home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-r ; process was terminated by signal 9
test_result_code, test_result_note = run_tests(tests_timeout)
File "./dev/run-tests-jenkins.py", line 140, in run_tests
test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
KeyError: -9
```
```
Traceback (most recent call last):
File "./dev/run-tests-jenkins.py", line 226, in <module>
main()
File "./dev/run-tests-jenkins.py", line 213, in main
test_result_code, test_result_note = run_tests(tests_timeout)
File "./dev/run-tests-jenkins.py", line 140, in run_tests
test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
KeyError: -10
```
This exception looks causing failing to update the comments in the PR. For example:
these comment just remain.
This always requires, for both reviewers and the author, a overhead to click and check the logs, which I believe are not really useful.
This PR proposes to leave the code in the PR comment messages and let update the comments.
## How was this patch tested?
Jenkins tests below, I manually gave the error code to test this.
Author: hyukjinkwon <gu...@gmail.com>
Closes #18399 from HyukjinKwon/jenkins-print-errors.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/7c7bc8fc
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/7c7bc8fc
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/7c7bc8fc
Branch: refs/heads/master
Commit: 7c7bc8fc0ff85fe70968b47433bb7757326a6b12
Parents: bfd73a7
Author: hyukjinkwon <gu...@gmail.com>
Authored: Sat Jun 24 10:14:31 2017 +0100
Committer: Sean Owen <so...@cloudera.com>
Committed: Sat Jun 24 10:14:31 2017 +0100
----------------------------------------------------------------------
dev/run-tests-jenkins.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/7c7bc8fc/dev/run-tests-jenkins.py
----------------------------------------------------------------------
diff --git a/dev/run-tests-jenkins.py b/dev/run-tests-jenkins.py
index 53061bc..914eb93 100755
--- a/dev/run-tests-jenkins.py
+++ b/dev/run-tests-jenkins.py
@@ -137,7 +137,9 @@ def run_tests(tests_timeout):
if test_result_code == 0:
test_result_note = ' * This patch passes all tests.'
else:
- test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
+ note = failure_note_by_errcode.get(
+ test_result_code, "due to an unknown error code, %s" % test_result_code)
+ test_result_note = ' * This patch **fails %s**.' % note
return [test_result_code, test_result_note]
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org