You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/11 14:14:18 UTC
[GitHub] [incubator-pekko-grpc] pjfanning opened a new pull request, #163: Delete crdt-example.proto
pjfanning opened a new pull request, #163:
URL: https://github.com/apache/incubator-pekko-grpc/pull/163
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #163: Delete crdt-example.proto
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #163:
URL: https://github.com/apache/incubator-pekko-grpc/pull/163#issuecomment-1674892291
So I just had a quick glance at the code and I am getting the impression that this is meant to be an example file, in which case its fine to delete but maybe we should make a reference to the file in our documentation somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #163: Delete crdt-example.proto
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #163:
URL: https://github.com/apache/incubator-pekko-grpc/pull/163#issuecomment-1674941991
I created https://github.com/apache/incubator-pekko-grpc/issues/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #163: Delete crdt-example.proto
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #163:
URL: https://github.com/apache/incubator-pekko-grpc/pull/163#issuecomment-1674898179
* it is checked into a test project
* my impression is that it was meant to be part of the testing of a PR but then it wasn't used
* if we were to document where you find example protos - what page would it go on? If we have no such page, would we create a page with just this proto?
* can't we add docs at any time?
* this file is a potential -1 in our release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning merged pull request #163: Delete crdt-example.proto
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #163:
URL: https://github.com/apache/incubator-pekko-grpc/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org