You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2014/10/03 03:31:12 UTC

Review Request 26306: Patch for KAFKA-1663

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26306/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1663
    https://issues.apache.org/jira/browse/KAFKA-1663


Repository: kafka


Description
-------

KAFKA-1663. Controller unable to shutdown after a soft failure.


Diffs
-----

  core/src/main/scala/kafka/controller/TopicDeletionManager.scala 219c4136e905a59a745c3a596c95d59b550e7383 

Diff: https://reviews.apache.org/r/26306/diff/


Testing
-------


Thanks,

Sriharsha Chintalapani

Re: Review Request 26306: Patch for KAFKA-1663

Posted by Guozhang Wang <gu...@linkedin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26306/#review55415
-----------------------------------------------------------



core/src/main/scala/kafka/controller/TopicDeletionManager.scala
<https://reviews.apache.org/r/26306/#comment95770>

    Can we change this comment accordingly, since we have other places calling resumeTopicDeletionThread() than these three cases.


- Guozhang Wang


On Oct. 3, 2014, 1:31 a.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26306/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 1:31 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1663
>     https://issues.apache.org/jira/browse/KAFKA-1663
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1663. Controller unable to shutdown after a soft failure.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/TopicDeletionManager.scala 219c4136e905a59a745c3a596c95d59b550e7383 
> 
> Diff: https://reviews.apache.org/r/26306/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>