[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

[gi...@git.apache.org]

eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients
URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743133
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java
 ##########
 @@ -50,16 +55,21 @@
      * @param featureProvider feature provider
      * @param statsLogger stats logger
      */
-    public EnsemblePlacementPolicy initialize(ClientConfiguration conf,
+    public default EnsemblePlacementPolicy initialize(ClientConfiguration conf,
                                               Optional<DNSToSwitchMapping> optionalDnsResolver,
                                               HashedWheelTimer hashedWheelTimer,
                                               FeatureProvider featureProvider,
-                                              StatsLogger statsLogger);
+                                              StatsLogger statsLogger) {
+        return initialize(conf);
 
 Review comment:
   @sijie for this comment and the others, the problem is that we must call legacy "initialize" method of 4.4 policies.
   So by default we will call the old initialize(conf) which will be noop
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services