You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org> on 2008/04/10 17:56:05 UTC

[jira] Created: (TAPESTRY-2342) The InjectPageWorker should use the ComponentSource service, rather than the RequestPageCache

The InjectPageWorker should use the ComponentSource service, rather than the RequestPageCache
---------------------------------------------------------------------------------------------

                 Key: TAPESTRY-2342
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2342
             Project: Tapestry
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.0.11
            Reporter: Howard M. Lewis Ship
            Priority: Trivial


Currently, it generates Javassist code like:

add method: private com.parametrix.earth.pages.survey.SurveyDebug _$read_inject_page_nextPage()
{
  org.apache.tapestry.internal.structure.Page page = _$requestPageCache.get("MyPage");
  return (com.examples.pages.MyPage) page.getRootElement().getComponent();
}

But the less runtime generated code, the better (minutely faster, and easier to debug), Using an injected ComponentSource, this would be more like:

return (om.examples.pages.MyPage) _$componentSource.getPage("MyPage");

Even in runtime generated code, Law of Demeter is still useful.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Resolved: (TAPESTRY-2342) The InjectPageWorker should use the ComponentSource service, rather than the RequestPageCache

Posted by "Ted Steen (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Steen resolved TAPESTRY-2342.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0.12

> The InjectPageWorker should use the ComponentSource service, rather than the RequestPageCache
> ---------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2342
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2342
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0.11
>            Reporter: Howard M. Lewis Ship
>            Assignee: Ted Steen
>            Priority: Trivial
>             Fix For: 5.0.12
>
>
> Currently, it generates Javassist code like:
> add method: private com.parametrix.earth.pages.survey.SurveyDebug _$read_inject_page_nextPage()
> {
>   org.apache.tapestry.internal.structure.Page page = _$requestPageCache.get("MyPage");
>   return (com.examples.pages.MyPage) page.getRootElement().getComponent();
> }
> But the less runtime generated code, the better (minutely faster, and easier to debug), Using an injected ComponentSource, this would be more like:
> return (om.examples.pages.MyPage) _$componentSource.getPage("MyPage");
> Even in runtime generated code, Law of Demeter is still useful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Assigned: (TAPESTRY-2342) The InjectPageWorker should use the ComponentSource service, rather than the RequestPageCache

Posted by "Ted Steen (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Steen reassigned TAPESTRY-2342:
-----------------------------------

    Assignee: Ted Steen

> The InjectPageWorker should use the ComponentSource service, rather than the RequestPageCache
> ---------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2342
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2342
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0.11
>            Reporter: Howard M. Lewis Ship
>            Assignee: Ted Steen
>            Priority: Trivial
>
> Currently, it generates Javassist code like:
> add method: private com.parametrix.earth.pages.survey.SurveyDebug _$read_inject_page_nextPage()
> {
>   org.apache.tapestry.internal.structure.Page page = _$requestPageCache.get("MyPage");
>   return (com.examples.pages.MyPage) page.getRootElement().getComponent();
> }
> But the less runtime generated code, the better (minutely faster, and easier to debug), Using an injected ComponentSource, this would be more like:
> return (om.examples.pages.MyPage) _$componentSource.getPage("MyPage");
> Even in runtime generated code, Law of Demeter is still useful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org