[GitHub] [skywalking] dmsolr commented on a change in pull request #7849: Fix wrong rules for checking lists in E2E

[GitBox <gi...@apache.org>]

dmsolr commented on a change in pull request #7849:
URL: https://github.com/apache/skywalking/pull/7849#discussion_r724740759



##########
File path: test/e2e-v2/cases/satellite/native-protocols/expected/logs-list.yml
##########
@@ -14,7 +14,7 @@
 # limitations under the License.
 
 logs:
-{{- range .logs }}
+{{- contains .logs }}

Review comment:
       As your explaining, `contains` is for checking the specific elements whether existed or not.
   In this case, I think it checks all elements. All log data should be in this pattern, right? So we keep `range` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org