You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/03 13:48:29 UTC

[GitHub] [skywalking-docker] hanahmily commented on a change in pull request #22: update ui docker enntry point script.

hanahmily commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-docker/pull/22#discussion_r681776376



##########
File path: ui/docker-entrypoint.sh
##########
@@ -20,7 +20,12 @@ set -e
 
 export LOGGING_CONFIG="webapp/logback.xml"
 
-[[ ! -z "$SW_OAP_ADDRESS" ]] && export COLLECTOR_RIBBON_LISTOFSERVERS=${SW_OAP_ADDRESS} && echo "COLLECTOR_RIBBON_LISTOFSERVERS=$COLLECTOR_RIBBON_LISTOFSERVERS"
-[[ ! -z "$SW_TIMEOUT" ]] && export COLLECTOR_RIBBON_READTIMEOUT=${SW_TIMEOUT} && echo "COLLECTOR_RIBBON_READTIMEOUT=$COLLECTOR_RIBBON_READTIMEOUT"
+if [[ ! -z "$SW_OAP_ADDRESS" ]]; then
+  address_arr=(${SW_OAP_ADDRESS//,/ })
+  for i in "${!address_arr[@]}"
+  do
+      JAVA_OPTS="${JAVA_OPTS} -Dspring.cloud.discovery.client.simple.instances.oap-service[$i].uri=${address_arr[$i]}"
+  done
+fi
 
-exec java -jar webapp/skywalking-webapp.jar "$@"

Review comment:
       `-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap` are invalid in jdk11




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org