You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/03/21 15:05:23 UTC

[GitHub] [maven-parent] cstamas opened a new pull request, #115: [MPOM-346] Do not run ITs in release

cstamas opened a new pull request, #115:
URL: https://github.com/apache/maven-parent/pull/115

   As it makes no sense, but in turn just worsens the already fragile release process. As preparation
   to release relMgr hopefully ensures that ITs are
   OK on CI and locally. If not, doh, new version
   will happen, so what?
   
   ---
   
   https://issues.apache.org/jira/browse/MPOM-397


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-parent] olamy commented on pull request #115: [MPOM-346] Do not run ITs in release

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #115:
URL: https://github.com/apache/maven-parent/pull/115#issuecomment-1479087892

   `-DskipTests` just skip tests execution. tests classes are still compiled and so tests-jar is build correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-parent] olamy commented on pull request #115: [MPOM-346] Do not run ITs in release

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #115:
URL: https://github.com/apache/maven-parent/pull/115#issuecomment-1478787413

   even tests could be skipped as long as the build is green... and using localCheckout as well will make it faster
   I usually do this: 
   ```mvn release:prepare release:perform -DskipTests -Darguments="-DskipTests" -DlocalCheckout=true -B```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-parent] cstamas commented on pull request #115: [MPOM-346] Do not run ITs in release

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #115:
URL: https://github.com/apache/maven-parent/pull/115#issuecomment-1479014000

   I agree very much here, but IMHO `-DskipTests` is bad and I tend to avoid it's use, I usually set up surefire to not fail when there is no selected tests and use `-Dtest=void` instead (or some expression that selects no UT/IT to run). With `-DskipTests` there is no tests-jar built (so to say, the build is less complete) if build have it, and may produce issues, see for example here https://issues.apache.org/jira/browse/MRESOURCES-288.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-parent] slawekjaranowski commented on pull request #115: [MPOM-346] Do not run ITs in release

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #115:
URL: https://github.com/apache/maven-parent/pull/115#issuecomment-1485818508

   After it we should review generated reports, eg for invoker will be not needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-parent] gnodet merged pull request #115: [MPOM-346] Do not run ITs in release

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #115:
URL: https://github.com/apache/maven-parent/pull/115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-parent] slawekjaranowski commented on pull request #115: [MPOM-346] Do not run ITs in release

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #115:
URL: https://github.com/apache/maven-parent/pull/115#issuecomment-1518677815

   Even more when we have multi module project like plugin-tools we have as parent maven-parent then ITs are not executed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org