You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/03/18 22:20:40 UTC
Review Request 70235: Fixed the persistent volume ownership to allow
apps to chown.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian Zhang.
Repository: mesos
Description
-------
Fixed the persistent volume ownership to allow apps to chown.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e
Diff: https://reviews.apache.org/r/70235/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 70235: Fixed the persistent volume ownership to
allow apps to chown.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/#review213789
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70235']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2978/mesos-review-70235
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2978/mesos-review-70235/logs/mesos-tests.log):
```
W0319 00:22:10.935292 22644 slave.cpp:3932] Ignoring shutdown framework 78ebb5e8-abc9-4273-b0af-04e126844af1-0000 because it is terminating
I0319 00:22:10.938289 19524 master.cpp:1295] Agent 78ebb5e8-abc9-4273-b0af-04e126844af1-S0 at slave(494)@192.10.1.6:65029 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0319 00:22:10.938289 19524 master.cpp:3330] Disconnecting agent 78ebb5e8-abc9-4273-b0af-04e126844af1-S0 at slave(494)@192.10.1.6:65029 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0319 00:22:10.938289 19524 master.cpp:3349] Deactivating agent 78ebb5e8-abc9-4273-b0af-04e126844af1-S0 at slave(494)@192.10.1.6:65029 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0319 00:22:10.939296 22976 hierarchical.cpp:391] Removed framework 78ebb5e8-abc9-4273-b0af-04e126844af1-0000
I0319 00:22:10.939296 22976 hierarchical.cpp:828] Agent 78ebb5e8-abc9-4273-b0af-04e126844af1-S0 deactivated
I0319 00:22:10.939296 18580 containerizer.cpp:2576] Destroying container 07d60320-f210-45bb-b935-3aeefeaeab54 in RUNNING state
I0319 00:22:10.939296 18580 containerizer.cpp:3278] Transitioning the state of container 07d60320-f210-45bb-b935-3aeefeaeab54 from RUNNING to DESTROYING
I0319 00:22:10.940289 18580 launcher.cpp:161] Asked to destroy container 07d60320-f210-45bb-b935-3aeefeaeab54
W0319 00:22:10.941294 18052 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=10348 to peer '192.10.1.6:51006': IO failed with error code: The specified network name is no longer available.
W0319 00:22:10.941294 18052 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10308 to peer '192.10.1.6:51007': IO failed with error code: The specified network name is no longer available.
I0319 00:2[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)
[----------] Global test environment tear-down
[==========] 1122 tests from 107 test cases ran. (503029 ms total)
[ PASSED ] 1121 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
2:11.042927 19524 containerizer.cpp:3117] Container 07d60320-f210-45bb-b935-3aeefeaeab54 has exited
I0319 00:22:11.071938 20296 master.cpp:1135] Master terminating
I0319 00:22:11.072906 18548 hierarchical.cpp:679] Removed agent 78ebb5e8-abc9-4273-b0af-04e126844af1-S0
I0319 00:22:11.438617 18052 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 18, 2019, 3:20 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70235/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 3:20 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the persistent volume ownership to allow apps to chown.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e
>
>
> Diff: https://reviews.apache.org/r/70235/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 70235: Fixed the persistent volume ownership to
allow apps to chown.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/#review213788
-----------------------------------------------------------
Can you link a ticket to the bug and provide some brief description of the issue?
- Jie Yu
On March 18, 2019, 10:20 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70235/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 10:20 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the persistent volume ownership to allow apps to chown.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e
>
>
> Diff: https://reviews.apache.org/r/70235/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 70235: Fixed the persistent volume ownership to
allow apps to chown.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70235/#review213798
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70235]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 19, 2019, 6:20 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70235/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 6:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the persistent volume ownership to allow apps to chown.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e
>
>
> Diff: https://reviews.apache.org/r/70235/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>