You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/07/22 04:38:41 UTC
[PR] test(frontend): cover MenuComponent grid/worker toggles, report generation, and name sizing [texera]
mengw15 opened a new pull request, #6757:
URL: https://github.com/apache/texera/pull/6757
### What changes were proposed in this PR?
Extends the existing `MenuComponent` spec to cover the toolbar methods it had
left untested
(`frontend/src/app/workspace/component/menu/menu.component.ts`).
> Note: the existing spec already covers most of the methods the issue lists
> (`getRunButtonBehavior`, `applyRunButtonBehavior`, `hasOperators`, the other
> toggles/handlers, name change). The remaining gaps were the four below.
5 tests cover:
- `toggleGrid` — sets the joint paper grid size from the `showGrid` flag.
- `toggleNumWorkers` — toggles the `hide-worker-count` class from the flag.
- `onClickGenerateReport` — shows the blocking notification and builds the report HTML from the snapshot + operator results.
- `adjustWorkflowNameWidth` — no-op without the name input; sizes the input in px otherwise.
The joint-graph wrapper, notification, and report services are stubbed. No
production code was changed.
### Any related issues, documentation, discussions?
Closes #6746
### How was this PR tested?
Extended unit tests, run locally in `frontend/` (all green; the failure path was
verified by breaking an assertion to confirm the suite goes red):
```
ng test --watch=false --include src/app/workspace/component/menu/menu.component.spec.ts
# Test Files 1 passed (1) | Tests 55 passed (55)
prettier --write <spec> # clean
eslint <spec> # clean
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover MenuComponent grid/worker toggles, report generation, and name sizing [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6757:
URL: https://github.com/apache/texera/pull/6757#issuecomment-5041918133
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@kunwp1`
You can notify them by mentioning `@kunwp1` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover MenuComponent grid/worker toggles, report generation, and name sizing [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6757:
URL: https://github.com/apache/texera/pull/6757#issuecomment-5042445073
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6757?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.94%. Comparing base ([`3da5f49`](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3e058fe`](https://app.codecov.io/gh/apache/texera/commit/3e058fee8b766f7219117c35c298e4a209485a00?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6757 +/- ##
=========================================
Coverage 74.94% 74.94%
Complexity 3446 3446
=========================================
Files 1160 1160
Lines 45798 45798
Branches 5071 5071
=========================================
Hits 34324 34324
Misses 9828 9828
Partials 1646 1646
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.18% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.82% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.15% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6757/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [3da5f49](https://app.codecov.io/gh/apache/texera/commit/3da5f49c0a3727b1b57756265e84a5957551c036?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6757?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover MenuComponent grid/worker toggles, report generation, and name sizing [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6757:
URL: https://github.com/apache/texera/pull/6757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover MenuComponent grid/worker toggles, report generation, and name sizing [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed pull request #6757: test(frontend): cover MenuComponent grid/worker toggles, report generation, and name sizing
URL: https://github.com/apache/texera/pull/6757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org