You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 09:13:17 UTC

[GitHub] [arrow-rs] jhorstmann commented on pull request #296: fix invalid null handling in filter

jhorstmann commented on pull request #296:
URL: https://github.com/apache/arrow-rs/pull/296#issuecomment-843000835


   I checked out the branch to have a look with a bit more context. The logic looks good and makes this kernel a lot easier to use. The test looks good and should cover exactly this problem.
   
   One minor thing: There is a doc comment with a warning about null values above the `filter` function, which is now out of data.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org