You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2008/10/04 10:39:44 UTC
[jira] Created: (WICKET-1859) Fail fast if super.init() is not
called in MyApplication#init()
Fail fast if super.init() is not called in MyApplication#init()
---------------------------------------------------------------
Key: WICKET-1859
URL: https://issues.apache.org/jira/browse/WICKET-1859
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-M3, 1.3.4
Environment: Any
Reporter: Martin Grigorov
Priority: Minor
Add a check whether "super.init()" is called in MyApplication#init().
Something similar to Component#onBeforeRender().
>From Wicket Users mailing list:
On Thu, 2008-10-02 at 09:35 -0700, Jonathan Locke wrote:
>
> btw, shouldn't we fail init if super isn't called in this case like those
> other protections we built in?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1859) Fail fast if super.init() is not
called in MyApplication#init()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-1859.
-------------------------------------
Resolution: Invalid
I just took a deep look at the implementation and here are my findings:
Currently (1.3.4 and 1.4-m3) Application#init() and WebApplication#init() have empty implementations. All the default settings are set in WebApplication#internalInit() which is being called separately in WicketFilter.init(FilterConfig).
So I don't see a reason to require super.init().
> Fail fast if super.init() is not called in MyApplication#init()
> ---------------------------------------------------------------
>
> Key: WICKET-1859
> URL: https://issues.apache.org/jira/browse/WICKET-1859
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.4, 1.4-M3
> Environment: Any
> Reporter: Martin Grigorov
> Priority: Minor
>
> Add a check whether "super.init()" is called in MyApplication#init().
> Something similar to Component#onBeforeRender().
> From Wicket Users mailing list:
> On Thu, 2008-10-02 at 09:35 -0700, Jonathan Locke wrote:
> >
> > btw, shouldn't we fail init if super isn't called in this case like those
> > other protections we built in?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.