You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Julie Tibshirani (JIRA)" <ji...@apache.org> on 2018/10/17 19:23:00 UTC
[jira] [Comment Edited] (LUCENE-8535) Should we drop support for
highlighting block-join queris
[ https://issues.apache.org/jira/browse/LUCENE-8535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654018#comment-16654018 ]
Julie Tibshirani edited comment on LUCENE-8535 at 10/17/18 7:22 PM:
--------------------------------------------------------------------
I initially added a dependency on ‘join’ as part of https://issues.apache.org/jira/browse/LUCENE-5929. This change addressed an elasticsearch issue where standard highlighting would not work on a nested query ([https://github.com/elastic/elasticsearch/issues/6420]). Because nested documents show up in the same _source as the top-level document, it was pretty natural to want the nested content to be highlighted when performing a nested query. I think we reluctantly added a dependency on ‘join’ because a better solution like a query visitor wasn’t readily available.
For additional context, this issue came up several years ago, before elasticsearch supported inner_hits and the ability to highlight nested + child documents directly.
was (Author: jtibshirani):
I initially added a dependency on ‘join’ as part of https://issues.apache.org/jira/browse/LUCENE-5929. This change addressed an elasticsearch issue where standard highlighting would not work on a nested query ([https://github.com/elastic/elasticsearch/issues/6420]). Because nested documents show up in the same _source as the top-level document, it was pretty natural to want the nested content to be highlighted when performing a nested query. I think we reluctantly added a dependency on ‘join’ because a better solution like a query visitor wasn’t readily available.
For additional context, this issue came up several years ago, before elasticsearch supported inner_hits and the ability to highlight nested + child documents.
> Should we drop support for highlighting block-join queris
> ---------------------------------------------------------
>
> Key: LUCENE-8535
> URL: https://issues.apache.org/jira/browse/LUCENE-8535
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: master (8.0)
> Reporter: Simon Willnauer
> Priority: Major
>
> This is a spin-off from LUCENE-6572. We currently depend on the block-join module which is due to the fact that we try to highlight the queries wrapped by the block join queries. The current discussion on LUCENE-6572 mentioned that this doesn't make much sense from an highlighting perspecitve and if we should drop support for it. Lucene 8.0 would be a good time to do so.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org