You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2019/06/02 00:36:54 UTC

[lucene-solr] branch jira/SOLR-13452_gradle_3 updated: SOLR-13452: Make task descriptions more consistent.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch jira/SOLR-13452_gradle_3
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/jira/SOLR-13452_gradle_3 by this push:
     new 604b227  SOLR-13452: Make task descriptions more consistent.
604b227 is described below

commit 604b227220dc82a71f8246767887f817a3305af5
Author: markrmiller <ma...@apache.org>
AuthorDate: Sat Jun 1 19:36:47 2019 -0500

    SOLR-13452: Make task descriptions more consistent.
---
 buildSrc/build.gradle                 |  2 +-
 lucene/analysis/icu/build.gradle      |  6 +++---
 lucene/analysis/kuromoji/build.gradle |  6 +++---
 lucene/analysis/nori/build.gradle     |  6 +++---
 lucene/analysis/opennlp/build.gradle  |  2 +-
 lucene/benchmark/build.gradle         | 14 ++++++--------
 6 files changed, 17 insertions(+), 19 deletions(-)

diff --git a/buildSrc/build.gradle b/buildSrc/build.gradle
index 7ce819e..84be33a 100644
--- a/buildSrc/build.gradle
+++ b/buildSrc/build.gradle
@@ -86,7 +86,7 @@ configurations {
 
 task buildTest(type: Test) {
   group = LifecycleBasePlugin.VERIFICATION_GROUP
-  description = 'Runs the build tests.'
+  description = 'Runs the build tests (if using a unix env and docker is available).'
 
   maxHeapSize = '1024m'
 
diff --git a/lucene/analysis/icu/build.gradle b/lucene/analysis/icu/build.gradle
index 510028a..991c51e 100644
--- a/lucene/analysis/icu/build.gradle
+++ b/lucene/analysis/icu/build.gradle
@@ -43,7 +43,7 @@ sourceSets {
 
 task genUtr30DataFiles(type: JavaExec) {
   group = 'Build Regenerate'
-  description = "Compile UTR30 rules."
+  description = "Compiles UTR30 rules."
   
   classpath = sourceSets.tools.runtimeClasspath
   main = 'org.apache.lucene.analysis.icu.GenerateUTR30DataFiles'
@@ -55,7 +55,7 @@ def resourcesDir = "${projectDir}/src/resources"
 
 task gennorm2() {
   group = 'Build Regenerate'
-  description = "Compile norm2 rules. Note that the gennorm2 and icupkg tools must be on your PATH. These tools are part of the ICU4C package. See http://site.icu-project.org/ or sudo apt install icu-devtools"
+  description = "Compiles norm2 rules. Note that the gennorm2 and icupkg tools must be on your PATH. These tools are part of the ICU4C package. See http://site.icu-project.org/ or sudo apt install icu-devtools"
   doLast {
     new File(buildDir, "gennorm2").mkdirs()
     exec {
@@ -73,7 +73,7 @@ task gennorm2() {
 
 task genrbbi(type: JavaExec) {
   group = 'Build Regenerate'
-  description = "Compile RBBI rules."
+  description = "Compiles RBBI rules."
   
   classpath = sourceSets.tools.runtimeClasspath
   main = 'org.apache.lucene.analysis.icu.RBBIRuleCompiler'
diff --git a/lucene/analysis/kuromoji/build.gradle b/lucene/analysis/kuromoji/build.gradle
index 3a7a34d..14d6594 100644
--- a/lucene/analysis/kuromoji/build.gradle
+++ b/lucene/analysis/kuromoji/build.gradle
@@ -67,9 +67,9 @@ task patchDict {
   dependsOn downloadDict
 }
 
-task buildDict(type: JavaExec) {
+task buildKuromojiDict(type: JavaExec) {
   group = 'Build Regenerate'
-  description = "Download, patch, and build dict for kuromoji."
+  description = "Downloads, patches, and builds dict for kuromoji."
   
   doFirst {
     def tree = fileTree("${projectDir}/src/resources/org/apache/lucene/analysis/ja/dict")
@@ -94,7 +94,7 @@ task buildDict(type: JavaExec) {
 }
 
 task regenerate {
-  dependsOn buildDict
+  dependsOn buildKuromojiDict
 }
 
 forbiddenApisTools {
diff --git a/lucene/analysis/nori/build.gradle b/lucene/analysis/nori/build.gradle
index 81cd22b..0ba8a4d 100644
--- a/lucene/analysis/nori/build.gradle
+++ b/lucene/analysis/nori/build.gradle
@@ -59,9 +59,9 @@ task downloadDict(type: org.apache.lucene.gradle.Download) {
   }
 }
 
-task buildDict(type: JavaExec) {
+task buildNoriDict(type: JavaExec) {
   group = 'Build'
-  description = "Download, patch, and build dict for kuromoji."
+  description = "Downloads, patches, and builds dict for nori."
   
   doFirst {
     def tree = fileTree("${projectDir}/org/apache/lucene/analysis/ko/dict")
@@ -85,7 +85,7 @@ task buildDict(type: JavaExec) {
 }
 
 task regenerate {
-  dependsOn buildDict
+  dependsOn buildNoriDict
 }
 
 forbiddenApisTools {
diff --git a/lucene/analysis/opennlp/build.gradle b/lucene/analysis/opennlp/build.gradle
index 748ab91..7f6c462 100644
--- a/lucene/analysis/opennlp/build.gradle
+++ b/lucene/analysis/opennlp/build.gradle
@@ -156,7 +156,7 @@ task trainLemmatizerTrainerME(type: JavaExec) {
 
 task trainTestModels {
   group = 'Build'
-  description = "Train all small test models for unit tests."
+  description = "Traines all small test models for unit tests."
 
   dependsOn trainSentenceDetector, trainTokenizerTrainer, trainPOSTaggerTrainer, trainChunkerTrainerME, trainTokenNameFinderTrainer, trainLemmatizerTrainerME
 }
diff --git a/lucene/benchmark/build.gradle b/lucene/benchmark/build.gradle
index 41c13ef..2cd5d9a 100644
--- a/lucene/benchmark/build.gradle
+++ b/lucene/benchmark/build.gradle
@@ -54,7 +54,7 @@ task downloadEnwiki(type: org.apache.lucene.gradle.Download) {
 
 task installEnwiki(){
   group = 'Benchmark Data'
-  description = "Install Enwiki data files."
+  description = "Installs Enwiki data files."
   doLast {
     ant.bunzip2(src: "${projectDir}/temp/enwiki-20070527-pages-articles.xml.bz2", dest:"${projectDir}/temp/")
   }
@@ -71,15 +71,14 @@ task downloadGeoNames(type: org.apache.lucene.gradle.Download) {
 
 task installGeoNames(){
   group = 'Benchmark Data'
-  description = "Install GeoNames data files."
+  description = "Installs GeoNames data files."
   doLast {
     new File("${workingDir}/geonames").mkdirs()
     ant.bunzip2(src: "${projectDir}/temp/allCountries.txt.bz2", dest:"${workingDir}/geonames")
   }
+  dependsOn downloadGeoNames
 }
 
-installGeoNames.dependsOn downloadGeoNames
-
 // Reuters
 
 task downloadReuters(type: org.apache.lucene.gradle.Download) {
@@ -92,11 +91,12 @@ task extractReuters(type: JavaExec) {
   main = 'org.apache.lucene.benchmark.utils.ExtractReuters'
   args "${workingDir}/reuters"
   args "${workingDir}/reuters-out"
+  dependsOn downloadReuters
 }
 
 task installReuters(){
   group = 'Benchmark Data'
-  description = "Install Reuters data files."
+  description = "Installs Reuters data files."
   doLast {
     new File("${workingDir}/reuters").mkdirs()
     ant.gunzip(src: "${projectDir}/temp/reuters21578.tar.gz", dest:"${projectDir}/temp/")
@@ -105,11 +105,9 @@ task installReuters(){
     tree.include '**/*.txt'
     tree.each { it.delete() }
   }
+  dependsOn extractReuters
 }
 
-installReuters.dependsOn extractReuters
-extractReuters.dependsOn downloadReuters
-
 
 forbiddenApisMain {
   bundledSignatures -= 'jdk-system-out'