You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/15 10:15:30 UTC

[GitHub] [tvm] manupa-arm commented on pull request #10242: [microNPU] Add MobileNetv2 test to network tests

manupa-arm commented on pull request #10242:
URL: https://github.com/apache/tvm/pull/10242#issuecomment-1040092717


   Thanks @jacobbohlin 
   
   I think we could refactor the tests here to be a single one with stimulus being the model url and accelerator.
   Moreover, lets write out a tuples of model url and accelerator variants for each tests -- therefore we have more control/visibility of what is being tested as opposed default parametric explosion of the test space.
   
   Some references that we have done this at other places, also feel free to migrate any utility that you feel we can re-use to aot_test_utils
   
   https://github.com/apache/tvm/blob/0009a308d82a321f2399923ab14b4c088461b4f2/tests/python/relay/aot/test_crt_aot_usmp.py#L205-L219
   
   https://github.com/apache/tvm/blob/0009a308d82a321f2399923ab14b4c088461b4f2/tests/python/relay/aot/test_crt_aot_usmp.py#L232-L240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org