You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@archiva.apache.org by ol...@apache.org on 2012/11/19 16:34:39 UTC

svn commit: r1411249 - in /archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva: proxy-connectors-rules.js repository-groups.js

Author: olamy
Date: Mon Nov 19 15:34:38 2012
New Revision: 1411249

URL: http://svn.apache.org/viewvc?rev=1411249&view=rev
Log:
reuse selector if possible

Modified:
    archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors-rules.js
    archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/repository-groups.js

Modified: archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors-rules.js
URL: http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors-rules.js?rev=1411249&r1=1411248&r2=1411249&view=diff
==============================================================================
--- archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors-rules.js (original)
+++ archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors-rules.js Mon Nov 19 15:34:38 2012
@@ -189,7 +189,6 @@ define("archiva.proxy-connectors-rules",
     this.availableProxyConnectors.id="availableProxyConnectors";
     this.update=update;
 
-
     $.each(this.proxyConnectorRulesViewModel.proxyConnectors(), function(idx, value) {
       //$.log(idx + ': ' + value.sourceRepoId() +":"+value.targetRepoId());
       var available=true;
@@ -230,10 +229,11 @@ define("archiva.proxy-connectors-rules",
       self.proxyConnectorRule.proxyConnectors.remove(proxyConnectorToRemove);
       self.availableProxyConnectors.push(proxyConnectorToRemove);
       $.log("size after:"+self.proxyConnectorRule.proxyConnectors().length);
-      $("#main-content" ).find("#proxy-connectors-rules-available-proxy-connectors" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).on("click", function(){
+      var mainContent=$("#main-content");
+      mainContent.find("#proxy-connectors-rules-available-proxy-connectors" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).on("click", function(){
         self.removeAvailable(proxyConnectorRulesViewModel,$(this).attr("data-source-repoId"),$(this).attr("data-target-repoId"));
       });
-      $("#main-content" ).find("#proxy-connectors-rules-edit-order-div" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).off("click");
+      mainContent.find("#proxy-connectors-rules-edit-order-div" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).off("click");
     }
 
     this.activateRemoveChoosen=function(proxyConnectorRulesViewModel){
@@ -257,10 +257,11 @@ define("archiva.proxy-connectors-rules",
       self.proxyConnectorRule.proxyConnectors.push(proxyConnectorToAdd);
       self.availableProxyConnectors.remove(proxyConnectorToAdd);
       $.log("size after:"+self.availableProxyConnectors().length);
-      $("#main-content" ).find("#proxy-connectors-rules-edit-order-div" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).on("click", function(){
+      var mainContent=$("#main-content");
+      mainContent.find("#proxy-connectors-rules-edit-order-div" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).on("click", function(){
         self.removeChoosen(proxyConnectorRulesViewModel,$(this).attr("data-source-repoId"),$(this).attr("data-target-repoId"));
       });
-      $("#main-content" ).find("#proxy-connectors-rules-available-proxy-connectors" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).off("click");
+      mainContent.find("#proxy-connectors-rules-available-proxy-connectors" ).find("[data-source-repoId="+sourceRepoId+"][data-target-repoId="+targetRepoId+"]" ).off("click");
     }
 
     this.activateRemoveAvailable=function(proxyConnectorRulesViewModel){

Modified: archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/repository-groups.js
URL: http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/repository-groups.js?rev=1411249&r1=1411248&r2=1411249&view=diff
==============================================================================
--- archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/repository-groups.js (original)
+++ archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/repository-groups.js Mon Nov 19 15:34:38 2012
@@ -61,8 +61,9 @@ function(jquery,i18n,jqueryTmpl,bootstra
       }
       self.repositoryGroup.repositories(repositories);
       self.repositoryGroup.modified(true);
-      $("#main-content").find("#repository-groups-edit-available-repositories").find(".icon-plus-sign" ).off("click");
-      $("#main-content").find("#repository-groups-edit-order-div").find(".icon-minus-sign" ).off("click");
+      var mainContent=$("#main-content");
+      mainContent.find("#repository-groups-edit-available-repositories").find(".icon-plus-sign" ).off("click");
+      mainContent.find("#repository-groups-edit-order-div").find(".icon-minus-sign" ).off("click");
       self.renderSortableAvailables(self.repositoryGroupsViewModel);
       self.renderSortableChoosed(self.repositoryGroupsViewModel);
     }