You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Xinyi Yan (Jira)" <ji...@apache.org> on 2020/09/25 05:06:00 UTC
[jira] [Commented] (PHOENIX-6159) Phoenix-pherf writes the result
file even disableRuntimeResult flag is true
[ https://issues.apache.org/jira/browse/PHOENIX-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201911#comment-17201911 ]
Xinyi Yan commented on PHOENIX-6159:
------------------------------------
[~elserj] [~mihir6692] [~jisaac] do you guys know why we are adding CSVFileResultHandler and allowing each thread to write the result to the file when the disableRuntimeResult flag is true? If no one concern, I will remove CSVFileResultHandler and/or add an extra check disableRuntimeResult before letting each handler write the result.
> Phoenix-pherf writes the result file even disableRuntimeResult flag is true
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-6159
> URL: https://issues.apache.org/jira/browse/PHOENIX-6159
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Xinyi Yan
> Priority: Major
>
> The ResultManager has a logic to check writeRuntimeResults and creates defaultHandler or minimalHandler([ResultManager|[https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ResultManager.java#L69])], but it doesn't represent the meaning of the writeRuntimeResults. If writeRuntimeResults is false, it should not add any ResultHandler for later use.
> The ([MultiThreadedRunner|[https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java#L109])] writes the result to the file without check the writeRuntimeResults value.
> I'm not sure if anyone is using this [disableRuntimeResult param in Pherf.java|https://github.com/apache/phoenix/blob/master/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L156], which is not presenting what it indicates. I prefer to fix the behavior and match the meaning of disableRuntimeResult.
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)