Re: [PR] CASSANDRA-21136 Reject writes that modify same row more than once in a transaction [cassandra]

["belliottsmith (via GitHub)" <gi...@apache.org>]

belliottsmith commented on code in PR #4583:
URL: https://github.com/apache/cassandra/pull/4583#discussion_r3072234672


##########
src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java:
##########
@@ -1007,6 +1006,60 @@ private List<TxnWrite.Fragment> getTxnWriteFragment(int index, ClientState state
         return fragments;
     }
 
+    public List<RowKey> getRowKeys(List<TxnWrite.Fragment> writeFragments)
+    {
+        List<RowKey> rowKeys = new ArrayList<>();
+
+        for (TxnWrite.Fragment writeFragment : writeFragments)
+        {
+            DecoratedKey key = writeFragment.key.partitionKey();
+            List<Clustering<?>> clusteringColumns = writeFragment.referenceOps.getClusterings();

Review Comment:
   there are also non-reference ops, i.e. the `baseUpdate`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org