You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/31 17:13:22 UTC
[PR] Remove StringUtils usages and prohibit StringUtils and CollectionUtils imports [shardingsphere]
terrymanu opened a new pull request, #39672:
URL: https://github.com/apache/shardingsphere/pull/39672
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove StringUtils usages and prohibit StringUtils and CollectionUtils imports [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39672:
URL: https://github.com/apache/shardingsphere/pull/39672#issuecomment-5487419594
### Result
**Review Result: Mergeable**
The latest commit, `c55ec91`, resolves the only previous blocking issue. No new required changes were found.
### Evidence
- [`SQLScriptUtils`](https://github.com/apache/shardingsphere/blob/c55ec91f6b5dfcf304e0c9e7dc3473878fad36eb/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/util/SQLScriptUtils.java#L93-L120) now declares the private helpers in call order: `getReader` before `containsNonWhitespace`.
- The latest commit only reorders these methods and does not change runtime behavior.
- All 17 focused unit tests passed.
- Spotless passed.
- Checkstyle passed with 0 violations.
- No `StringUtils` or `CollectionUtils` imports remain in Java or Groovy sources.
### Coverage
- Reviewed head: [`c55ec91`](https://github.com/apache/shardingsphere/commit/c55ec91f6b5dfcf304e0c9e7dc3473878fad36eb).
- GitHub’s authoritative 9-file scope matches the local triple-dot comparison.
- Reviewed the utility import restriction, AES configuration normalization, MySQL `BIT_COUNT`, Docker version parsing, SQL script blank filtering, and external parser case filtering.
- Root-cause, blast-radius, contract, test-validity, and regression passes found no unresolved evidence gaps.
- This is a code-correctness result only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove StringUtils usages and prohibit StringUtils and CollectionUtils imports [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39672:
URL: https://github.com/apache/shardingsphere/pull/39672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org