[jira] [Commented] (RAT-190) False negatives(?) in apache rat license checking

["Philipp Ottlinger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RAT-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304130#comment-14304130 ] 

Philipp Ottlinger commented on RAT-190:
---------------------------------------

Hi [~ddumont],
I'm still not clear whether I get your problem.

If I use my enhanced pom and your test project I get a build failure and rat.txt contains:
{code}
 !????? src/main/java/com/mycompany/app/MailComposeView.js
 
*****************************************************
 Printing headers for files without AL header...
 
=======================================================================
==src/main/java/com/mycompany/app/MailComposeView.js
=======================================================================
/* Copyright IBM Corp. 2014  All Rights Reserved.                    */
...
{code}
This happens with:
{code}
Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T22:58:10+02:00)
Java version: 1.7.0_65, vendor: Oracle Corporation
and
Java version: 1.8.0_31, vendor: Oracle Corporation
{code}

In case you want to fix the recognition of your JS file you need to add another pattern to your configuration section of rat as I tried to write in my above comment:
{code}
<pattern>Copyright IBM Corp. 2014</pattern>
{code}

Adding this line makes RAT recognize your fail and the build goes green again.

Feel free to comment - otherwise I'd close this issue as Won'tFix.

Thanks




> False negatives(?) in apache rat license checking
> -------------------------------------------------
>
>                 Key: RAT-190
>                 URL: https://issues.apache.org/jira/browse/RAT-190
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.8, 0.11
>            Reporter: Dan Dumont
>         Attachments: complete-pom.xml, test.zip
>
>
> We're using rat to enforce our internal copyright on all of our source files.
> We're seeing it missing files that should be flagged.  Here's part of our pom:
> <licenses>
>   <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
>     <licenseFamilyCategory>IBMCL</licenseFamilyCategory>
>     <licenseFamilyName>IBM Copyright</licenseFamilyName>
>     <notes></notes>
>     <patterns>
>       <pattern>Copyright IBM Corp. 2015</pattern>
>       <pattern>Copyright IBM Corp. 2014, 2015</pattern>
>       <pattern>Copyright IBM Corp. 2013, 2015</pattern>
>     </patterns>
>   </license>
> </licenses>
> <licenseFamilies>
>   <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
>   <familyName>IBM Copyright</familyName>
> </licenseFamily>
> </licenseFamilies>
> The file in question is "included" as reported by running with debug output...  but the file's copyright is:
> /* Copyright IBM Corp. 2014  All Rights Reserved.                    */



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)