You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2021/07/13 11:04:30 UTC
[lucene-solr] 01/02: SOLR-15485: action post-commit review feedback
(#213)
This is an automated email from the ASF dual-hosted git repository.
cpoerschke pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit 38d7bc50b77d37b844fcc6672f49c7f70ca56641
Author: Christine Poerschke <cp...@apache.org>
AuthorDate: Tue Jul 13 11:23:57 2021 +0100
SOLR-15485: action post-commit review feedback (#213)
Resolved Conflicts:
gradle/validation/validate-source-patterns.gradle
---
solr/core/src/java/org/apache/solr/core/CoreContainer.java | 2 +-
solr/core/src/test/org/apache/solr/cloud/OverseerTest.java | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/solr/core/src/java/org/apache/solr/core/CoreContainer.java b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
index 2c4ab4c..77c0346 100644
--- a/solr/core/src/java/org/apache/solr/core/CoreContainer.java
+++ b/solr/core/src/java/org/apache/solr/core/CoreContainer.java
@@ -1138,7 +1138,7 @@ public class CoreContainer {
} finally {
try {
if (updateShardHandler != null) {
- customThreadPool.submit(() -> updateShardHandler.close());
+ customThreadPool.submit(updateShardHandler::close);
}
} finally {
try {
diff --git a/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java b/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java
index f4b2559..88ab70a 100644
--- a/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java
@@ -327,15 +327,15 @@ public class OverseerTest extends SolrTestCaseJ4 {
ExecutorService customThreadPool = ExecutorUtil.newMDCAwareCachedThreadPool(new SolrNamedThreadFactory("closeThreadPool"));
for (ZkController zkController : zkControllers) {
- customThreadPool.submit( () -> zkController.close());
+ customThreadPool.submit(zkController::close);
}
for (HttpShardHandlerFactory httpShardHandlerFactory : httpShardHandlerFactorys) {
- customThreadPool.submit( () -> httpShardHandlerFactory.close());
+ customThreadPool.submit(httpShardHandlerFactory::close);
}
for (UpdateShardHandler updateShardHandler : updateShardHandlers) {
- customThreadPool.submit( () -> updateShardHandler.close());
+ customThreadPool.submit(updateShardHandler::close);
}
for (SolrClient solrClient : solrClients) {
@@ -343,7 +343,7 @@ public class OverseerTest extends SolrTestCaseJ4 {
}
for (ZkStateReader reader : readers) {
- customThreadPool.submit( () -> reader.close());
+ customThreadPool.submit(reader::close);
}
for (SolrZkClient solrZkClient : zkClients) {
@@ -356,7 +356,7 @@ public class OverseerTest extends SolrTestCaseJ4 {
for (Overseer overseer : overseers) {
- customThreadPool.submit( () -> overseer.close());
+ customThreadPool.submit(overseer::close);
}
ExecutorUtil.shutdownAndAwaitTermination(customThreadPool);