You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "christophd (via GitHub)" <gi...@apache.org> on 2023/04/26 08:55:02 UTC
[GitHub] [camel-k] christophd opened a new pull request, #4278: chore: Support platform selection on IntegrationKit
christophd opened a new pull request, #4278:
URL: https://github.com/apache/camel-k/pull/4278
- Do only wakeup matching integration kits when waiting for selected platform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#issuecomment-1527619176
Please, rebase as we solved the github actions issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#issuecomment-1530963550
@squakez rebase done, could you please trigger the workflow once again 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#issuecomment-1525183076
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#discussion_r1177572013
##########
pkg/controller/integrationkit/integrationkit_controller.go:
##########
@@ -148,6 +148,11 @@ func add(_ context.Context, mgr manager.Manager, r reconcile.Reconciler) error {
}
for _, kit := range list.Items {
+ if v, ok := kit.Annotations[v1.PlatformSelectorAnnotation]; ok && v != p.Name {
+ // integration kit is waiting for another platform - skip it now
Review Comment:
Would it make sense to log it by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#issuecomment-1523244524
@oscerd @squakez I have added logging when skipping kits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a diff in pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#discussion_r1177608320
##########
pkg/controller/integrationkit/integrationkit_controller.go:
##########
@@ -148,6 +148,11 @@ func add(_ context.Context, mgr manager.Manager, r reconcile.Reconciler) error {
}
for _, kit := range list.Items {
+ if v, ok := kit.Annotations[v1.PlatformSelectorAnnotation]; ok && v != p.Name {
+ // integration kit is waiting for another platform - skip it now
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on a diff in pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on code in PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#discussion_r1177723688
##########
pkg/controller/integrationkit/integrationkit_controller.go:
##########
@@ -148,6 +148,11 @@ func add(_ context.Context, mgr manager.Manager, r reconcile.Reconciler) error {
}
for _, kit := range list.Items {
+ if v, ok := kit.Annotations[v1.PlatformSelectorAnnotation]; ok && v != p.Name {
+ // integration kit is waiting for another platform - skip it now
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4278:
URL: https://github.com/apache/camel-k/pull/4278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #4278: chore: Support platform selection on IntegrationKit
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #4278:
URL: https://github.com/apache/camel-k/pull/4278#issuecomment-1525181093
@oscerd could you please (re)trigger the failed job? hopefully only a hiccup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org