You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "RyanSkraba (via GitHub)" <gi...@apache.org> on 2023/06/16 17:45:42 UTC
[GitHub] [flink] RyanSkraba opened a new pull request, #22814: [FLINK-32008][protobuf] Ensure bulk persistence is not supported
RyanSkraba opened a new pull request, #22814:
URL: https://github.com/apache/flink/pull/22814
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
It's currently possible to use protobuf as a format to read/write files that store bulk records. This is not actually supported by the [protobuf format](https://protobuf.dev/programming-guides/techniques/#streaming) itself. Some techniques can be used to frame the data, but from the discussion on the [mailing list](https://lists.apache.org/thread/z9tqdqrhj12c17wqsdbm5fhzonqq5kp0), this doesn't seem like a useful thing to do.
The protobuf format is apt for serializing individual records framed inside other containers (like a Kafka message). For bulk persistence, the parquet format using the protobuf-oriented API is a better standard than rolling our own.
The current state falls back to writing individual records as binaries delimited by newlines `0x0a`, and this may silently succeed but the resulting files are very unlikely to be successfully read (or even readable, since a newline can be indistinguishable from a real tag).
## Brief change log
- Add a separate `PbFileFormatFactory` that throws a ValidationException when attempting to create a `BulkEncodingFormat` or `BulkDecodingFormat`.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change added tests and can be verified as follows:
- Added a test to `ProtobufSQLITCaseTest` when attempting to write with the `filesystem` connector.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no** (Except for a provided/optional flink jar)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no** (except indirectly)
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **JavaDocs** and a meaningful ValidationException message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao merged pull request #22814: [FLINK-32008][protobuf] Ensure bulk persistence is not supported
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao merged PR #22814:
URL: https://github.com/apache/flink/pull/22814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #22814: [FLINK-32008][protobuf] Ensure bulk persistence is not supported
Posted by "RyanSkraba (via GitHub)" <gi...@apache.org>.
RyanSkraba commented on code in PR #22814:
URL: https://github.com/apache/flink/pull/22814#discussion_r1232566820
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/ProtobufSQLITCaseTest.java:
##########
@@ -328,4 +331,33 @@ public void testSinkWithNullLiteralWithEscape() throws Exception {
MapTest.InnerMessageTest innerMessageTest = mapTest.getMap2Map().get("b");
assertEquals(MapTest.InnerMessageTest.getDefaultInstance(), innerMessageTest);
}
+
+ @Test
+ public void testUnsupportedBulkFilesystemSink() {
+ env().setParallelism(1);
+ String sql =
+ "create table bigdata_sink ( "
+ + " a int, "
+ + " map1 map<string,string>,"
+ + " map2 map<string, row<a int, b bigint>>"
+ + ") with ("
+ + " 'connector' = 'filesystem', "
+ + " 'path' = '/tmp/unused', "
+ + " 'format' = 'protobuf', "
+ + " 'protobuf.message-class-name' = 'org.apache.flink.formats.protobuf.testproto.MapTest'"
+ + ")";
+ tEnv().executeSql(sql);
Review Comment:
I would have preferred to throw the exception here, but I didn't find the right hook into the connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22814: [FLINK-32008][protobuf] Ensure bulk persistence is not supported
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22814:
URL: https://github.com/apache/flink/pull/22814#issuecomment-1595046994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3d234a0226eb17de727e7fa8467b12242a727e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c3d234a0226eb17de727e7fa8467b12242a727e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3d234a0226eb17de727e7fa8467b12242a727e6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org