[jira] [Assigned] (SLING-2926) Wasted work in AbstractGetAclServlet.doGet()

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler reassigned SLING-2926:
---------------------------------------

    Assignee: Carsten Ziegeler
    
> Wasted work in AbstractGetAclServlet.doGet()
> --------------------------------------------
>
>                 Key: SLING-2926
>                 URL: https://issues.apache.org/jira/browse/SLING-2926
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Carsten Ziegeler
>              Labels: patch, perfomance
>         Attachments: patch.diff
>
>
> The problem appears in revision 1495454.  I attached a one-line patch
> that fixes it.
> In method "AbstractGetAclServlet.doGet", the loop over "selectors"
> should break immediately after "isTidy" is set to "true".  All the
> iterations after "isTidy" is set to "true" do not perform any useful
> work, at best they just set "isTidy" again to "true".
> Method "isLive" in class "ResourceResolverContext" has a similar loop
> (over "dynamicProviders"), and this loop breaks immediately after
> "result" is set to "false", just like in the proposed patch.  Other
> methods (e.g., "FactoryPreconditions.checkPreconditions",
> "JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
> "SecondPassVisitor.appendPageDirective") also have similar loops with
> similar breaks, just like in the proposed patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira