[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#discussion_r387435286
 
 

 ##########
 File path: lucene/queries/src/java/org/apache/lucene/queries/function/FunctionValues.java
 ##########
 @@ -90,6 +93,9 @@ public int ordVal(int doc) throws IOException {
    * @return the number of unique sort ordinals this instance has
    */
   public int numOrd() { throw new UnsupportedOperationException(); }
+
 
 Review comment:
   Really needs javadoc explaining what this is.  See TPI.matchCost for inspiration.  I suggest:
   
   > An estimate of the expected cost to return a value for a document.
   > It's intended to be used by TwoPhaseIterator.matchCost implementations.
   > Returns an expected cost in number of simple operations like addition, multiplication,
   > comparing two numbers and indexing an array.
   > The returned value must be positive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org