[GitHub] [iceberg] dpaani commented on a diff in pull request #7066: S3 Credentials provider support in DefaultAwsClientFactory #7063

["dpaani (via GitHub)" <gi...@apache.org>]

dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1136433061


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -91,13 +92,16 @@ private static AwsClientFactory loadClientFactory(String impl, Map<String, Strin
   static class DefaultAwsClientFactory implements AwsClientFactory {
     private AwsProperties awsProperties;
 
+    private Region region;
+
     DefaultAwsClientFactory() {
       awsProperties = new AwsProperties();
     }
 
     @Override
     public S3Client s3() {
       return S3Client.builder()
+          .region(this.region)

Review Comment:
   This is good suggestion @JonasJ-ap . I made the change. Please check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org