You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by nir-sopher <gi...@git.apache.org> on 2017/07/18 18:41:51 UTC
[GitHub] incubator-trafficcontrol pull request #735: User tenancy validation
GitHub user nir-sopher opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/735
User tenancy validation
Updating the user API to enforce user tenancy access control.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nir-sopher/incubator-trafficcontrol user-tenancy-validation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/735.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #735
----
commit 0d2194eac7023361b348f7ab02c81caa3c5bcd1e
Author: nir sopher <ni...@qwilt.com>
Date: 2017-06-14T12:54:49Z
users tenancy checks - API
commit 6a122c087c3f2e6eb110a79aa19ba03fb84cf39a
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-14T15:11:15Z
User tenancy verification - UI entry point
commit 936768da5a49e2885fc0ed03bfab1934e3684ef2
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-20T02:33:51Z
Current user update - cannot change tenancy
commit 49eba241748d132164ebba66377da5dd05604a24
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-25T14:50:26Z
User tenancy verification - index test
commit aa3bb8a41bb640e6b513f1b13c455b37770d8b2d
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-25T15:38:06Z
Tenancy tests - unifications
commit 52c5ed42cef22f67fe33ee50811446db3fdeffcb
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-26T13:22:11Z
User tenancy cannot be changed
commit 78c4b17984a66c04b76e8b2496b5868936df40dc
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-27T05:39:11Z
Revert "User tenancy cannot be changed"
This reverts commit f67b3e60a7f56aa92c40d4dfda195d9a6db3f328.
commit 473b62d40e110521a151d8b319b2f28f1c7bcb62
Author: nir-sopher <ni...@qwilt.com>
Date: 2017-06-27T06:57:18Z
User tenancy - fixing API return codes in some cases 403->400
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #735: [TC-427] User tenancy validation
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/735#discussion_r128346564
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -477,6 +506,13 @@ sub update_current {
return $self->alert( "Profile cannot be updated because '" . $user->{username} . "' is logged in as LDAP." );
}
+ if ( defined( $user->{"tenantId"} ) ) {
--- End diff --
Can you make it so you can update your current user....but only with an approved tenant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #735: [TC-427] User tenancy validation
Posted by nir-sopher <gi...@git.apache.org>.
Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/735#discussion_r128364144
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -477,6 +506,13 @@ sub update_current {
return $self->alert( "Profile cannot be updated because '" . $user->{username} . "' is logged in as LDAP." );
}
+ if ( defined( $user->{"tenantId"} ) ) {
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #735: [TC-427] User tenancy validation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/735
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---