You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/10/30 23:43:33 UTC

Review Request 63435: Remove inaccurate "Initializing sandbox" message

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63435/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Bill Farner.


Repository: aurora


Description
-------

The message is no longer completely accurate, now that we remain in 
`STARTING` until health checks have passed.


Diffs
-----

  src/main/python/apache/aurora/executor/aurora_executor.py aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 


Diff: https://reviews.apache.org/r/63435/diff/1/


Testing
-------

./pants test.pytest src/test/python::


File Attachments
----------------

Screen Shot 2017-10-31 at 00.16.56.png
  https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png


Thanks,

Stephan Erb

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

Posted by Stephan Erb <se...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63435/#review189728
-----------------------------------------------------------



I have pushed this for now as is, hopefully I have time later to revisit for an improvement.

- Stephan Erb


On Oct. 31, 2017, 12:43 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63435/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2017, 12:43 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The message is no longer completely accurate, now that we remain in 
> `STARTING` until health checks have passed.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 
> 
> 
> Diff: https://reviews.apache.org/r/63435/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python::
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-31 at 00.16.56.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63435/#review189665
-----------------------------------------------------------


Ship it!




Also +1 to shipping as-is, given that inaccurate message is more harmful than no message at all.

- David McLaughlin


On Oct. 30, 2017, 11:43 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63435/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 11:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The message is no longer completely accurate, now that we remain in 
> `STARTING` until health checks have passed.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 
> 
> 
> Diff: https://reviews.apache.org/r/63435/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python::
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-31 at 00.16.56.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

Posted by David McLaughlin <da...@dmclaughlin.com>.


> On Oct. 30, 2017, 11:52 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py
> > Line 98 (original), 98 (patched)
> > <https://reviews.apache.org/r/63435/diff/1/?file=1873068#file1873068line98>
> >
> >     Bonus points for an `Awaiting task health checks` message when applicable.

Big +1 for adding messages to reflect the new behavior, this would be especially nice as we see a lot of tasks (especially crons and adhoc tasks) sit in this status for a long time now.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63435/#review189662
-----------------------------------------------------------


On Oct. 30, 2017, 11:43 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63435/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 11:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The message is no longer completely accurate, now that we remain in 
> `STARTING` until health checks have passed.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 
> 
> 
> Diff: https://reviews.apache.org/r/63435/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python::
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-31 at 00.16.56.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63435/#review189662
-----------------------------------------------------------


Ship it!




LGTM since the current config lies, but added a wish list item.


src/main/python/apache/aurora/executor/aurora_executor.py
Line 98 (original), 98 (patched)
<https://reviews.apache.org/r/63435/#comment266873>

    Bonus points for an `Awaiting task health checks` message when applicable.


- Bill Farner


On Oct. 30, 2017, 4:43 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63435/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 4:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The message is no longer completely accurate, now that we remain in 
> `STARTING` until health checks have passed.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 
> 
> 
> Diff: https://reviews.apache.org/r/63435/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python::
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-31 at 00.16.56.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63435/#review189669
-----------------------------------------------------------



Master (87eb891) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 30, 2017, 11:43 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63435/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 11:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The message is no longer completely accurate, now that we remain in 
> `STARTING` until health checks have passed.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py aeb3a4d4420c2a7a95ec9a866633bc0c0897ac56 
> 
> 
> Diff: https://reviews.apache.org/r/63435/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/test/python::
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-31 at 00.16.56.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/685d76fe-3db2-4761-80c1-f0af83642d0e__Screen_Shot_2017-10-31_at_00.16.56.png
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>