[GitHub] [spark] srowen commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector
URL: https://github.com/apache/spark/pull/27978#discussion_r396108095
 
 

 ##########
 File path: project/MimaExcludes.scala
 ##########
 @@ -38,7 +38,11 @@ object MimaExcludes {
   lazy val v31excludes = v30excludes ++ Seq(
     // [SPARK-31077] Remove ChiSqSelector dependency on mllib.ChiSqSelectorModel
     // private constructor
-    ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel.this")
+    ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel.this"),
+    // [SPARK-31127] Implement abstract Selector
+    ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel"),
 
 Review comment:
   Weird: this class is still there, right? is this still definitely a MiMa error? I'm trying to figure out if we're missing something here that causes an incompatible change.
   
   This would only go into 3.1 right?
   The refactoring looks OK; hard to evaluate it all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org