[GitHub] [incubator-dubbo] zhaixiaoxiang commented on issue #3076: [Dubbo-3069] Fix NumberFormatException for input string ""

["zhaixiaoxiang (GitHub)" <gi...@apache.org>]

> Hi, @zhaixiaoxiang
> 
> ```
> if (type == char.class || type == Character.class) {
>     return value.length() > 0 ? value.charAt(0) : '\0';
> }
> ```
> Return '\0' may be confusing.
> 
> How about put the `if StringUtils.isRealBlank(value)` in the first line of this method?
> But be careful if the '\0' is used in other place.

Emm, I'm not sure whether '\0' us used in other place.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3076 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org