You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/10 02:33:18 UTC
[GitHub] [doris] SaintBacchus opened a new pull request, #13231: impl node type
SaintBacchus opened a new pull request, #13231:
URL: https://github.com/apache/doris/pull/13231
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13231: [feature-wip](CN Node)Support compute node type
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13231:
URL: https://github.com/apache/doris/pull/13231#discussion_r996457552
##########
be/src/common/config.h:
##########
@@ -872,6 +872,8 @@ CONF_mBool(enable_new_load_scan_node, "false");
// Temp config. True to use new file scanner. Will remove after fully test.
CONF_mBool(enable_new_file_scanner, "false");
+CONF_mString(be_node_type, "be");
Review Comment:
how about `mixed`, `compute`, etc.
And I think this is not a modifiable config, so it should be `CONF_String`
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1788,4 +1788,6 @@ public class Config extends ConfigBase {
@ConfField(mutable = false)
public static int statistic_task_scheduler_execution_interval_ms = 60 * 1000;
+ @ConfField(mutable = true, masterOnly = false)
+ public static int backend_num_for_federation = 3;
Review Comment:
Add some comment for this config
##########
fe/fe-core/src/main/java/org/apache/doris/resource/Tag.java:
##########
@@ -65,6 +66,7 @@ public class Tag implements Writable {
public static final String VALUE_DEFAULT_CLUSTER = "default_cluster";
public static final String VALUE_DEFAULT_TAG = "default";
public static final String VALUE_INVALID_TAG = "invalid";
+ public static final String VALUE_NODE_TYPE_TAG = "be";
Review Comment:
Actually, there are some predefined field like `TYPE_FUNCTION` and `VALUE_COMPUTATION`, they are supposed to do this feature.
So I think we can use them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13231: [feature-wip](CN Node)Support compute node
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13231:
URL: https://github.com/apache/doris/pull/13231#issuecomment-1286456409
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.1 seconds
load time: 643 seconds
storage size: 17154810702 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021044937_clickbench_pr_32318.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13231: [feature-wip](CN Node)Support compute node
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13231:
URL: https://github.com/apache/doris/pull/13231#issuecomment-1284036338
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.76 seconds
load time: 585 seconds
storage size: 17154768597 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221019214037_clickbench_pr_31440.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13231: [feature-wip](CN Node)Support compute node
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13231:
URL: https://github.com/apache/doris/pull/13231#discussion_r1002430817
##########
fe/fe-core/src/main/java/org/apache/doris/system/Backend.java:
##########
@@ -123,6 +123,9 @@ public enum BackendState {
// creating this everytime we get it.
@SerializedName(value = "locationTag", alternate = {"tag"})
private Tag locationTag = Tag.DEFAULT_BACKEND_TAG;
+
Review Comment:
We need to persist this field(annotated with `@SerializedName`), otherwise, other non-master FE will not known this tag.
##########
be/src/common/config.h:
##########
@@ -858,6 +858,16 @@ CONF_mInt64(nodechannel_pending_queue_max_bytes, "67108864");
// so as to avoid occupying the execution thread for a long time.
CONF_mInt32(max_fragment_start_wait_time_seconds, "30");
+// Temp config. True to use new file scan node to do load job. Will remove after fully test.
Review Comment:
What is this for? I have just removed this 2 config?
##########
docs/zh-CN/docs/sql-manual/sql-reference/Show-Statements/SHOW-BACKENDS.md:
##########
@@ -52,6 +52,7 @@ SHOW BACKENDS
10. UsedPct 表示磁盘已使用量百分比。
11. ErrMsg 用于显示心跳失败时的错误信息。
12. Status 用于以 JSON 格式显示BE的一些状态信息, 目前包括最后一次BE汇报其tablet的时间信息。
+ 13. NodeRole用于展示节点角色, 现在有两种类型: Mix代表原来的节点类型, computation代表只做计算的节点类型.
Review Comment:
I add a new column `HeartbeatFailureCounter` in #13568.
But I forgot to modify the document here.
Could you please add it for me? The content is:
```
13. HeartbeatFailureCounter：现在当前连续失败的心跳次数，如果次数超过 `max_backend_heartbeat_failure_tolerance_count` 配置，则 isAlive 字段会置为 false。
```
English:
```
13. HeartbeatFailureCounter: The current number of heartbeats that have failed consecutively. If the number exceeds the `max_backend_heartbeat_failure_tolerance_count` configuration, the isAlive will be set to false.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13231: [feature-wip](CN Node)Support compute node
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13231:
URL: https://github.com/apache/doris/pull/13231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org