You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/01 06:44:32 UTC
Review Request 54245: Updated signatures of v1 agent API handlers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54245/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Repository: mesos
Description
-------
Moved the position of `contentType` argument in the handlers and
renamed it to `acceptType` to be consistent.
Diffs
-----
src/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2
src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa
Diff: https://reviews.apache.org/r/54245/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 54245: Updated signatures of v1 agent API handlers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54245/
-----------------------------------------------------------
(Updated Dec. 2, 2016, 12:59 a.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
rebased. NNFR.
Repository: mesos
Description
-------
Moved the position of `contentType` argument in the handlers and
renamed it to `acceptType` to be consistent.
Diffs (updated)
-----
src/slave/http.cpp ace3575fd3a330f788e678283bc05e806cf9b264
src/slave/slave.hpp cfec9dd5fa3550ba1192fc86b1ff0d73ee1671e0
Diff: https://reviews.apache.org/r/54245/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 54245: Updated signatures of v1 agent API handlers.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54245/#review157633
-----------------------------------------------------------
Ship it!
Nice cleanup!
- Anand Mazumdar
On Dec. 1, 2016, 6:44 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54245/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 6:44 a.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved the position of `contentType` argument in the handlers and
> renamed it to `acceptType` to be consistent.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2
> src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa
>
> Diff: https://reviews.apache.org/r/54245/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>