You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/04/05 21:45:25 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #446: Phoenix 5136

swaroopak commented on a change in pull request #446: Phoenix 5136
URL: https://github.com/apache/phoenix/pull/446#discussion_r272753370
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/expression/AndOrExpression.java
 ##########
 @@ -36,6 +36,8 @@
 public abstract class AndOrExpression extends BaseCompoundExpression {
     // Remember evaluation of child expression for partial evaluation
     private BitSet partialEvalState;
+    // true if we have seen NULL as the value of some child expression
 
 Review comment:
   Redundant comment. Please remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services