You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/07/13 03:42:35 UTC

[GitHub] [echarts] plainheart commented on a change in pull request #15335: feat(effectScatter): make ripple effect count configurable

plainheart commented on a change in pull request #15335:
URL: https://github.com/apache/echarts/pull/15335#discussion_r668403850



##########
File path: src/chart/helper/EffectSymbol.ts
##########
@@ -38,7 +36,8 @@ interface RippleEffectCfg {
     zlevel?: number
     symbolType?: string
     color?: ZRColor
-    rippleEffectColor?: ZRColor
+    rippleEffectColor?: ZRColor,
+    effectCount?: number

Review comment:
       Good name! Now it's `number`, just like `period`, `scale`, all of them have no prefix `ripple`. Should we add the prefix for the new option `number`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org