You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/19 11:52:59 UTC
[jira] [Created] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Ivan Kelly created BOOKKEEPER-466:
-------------------------------------
Summary: ZooKeeper test utility sets the port number as the tickTime
Key: BOOKKEEPER-466
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500187#comment-13500187 ]
Flavio Junqueira commented on BOOKKEEPER-466:
---------------------------------------------
This is a funny one... Are you setting it low to force it to go with 2*tickTime? It might be a better idea to raise the value to something like 10k. Otherwise, the patch is good.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501115#comment-13501115 ]
Ivan Kelly commented on BOOKKEEPER-466:
---------------------------------------
https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L194
It's tickTime that we're setting here, not minSessionTime. What was happening was that the port number was being set as the tickTime, which then caused the minSessionTime to be too big.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501830#comment-13501830 ]
Flavio Junqueira commented on BOOKKEEPER-466:
---------------------------------------------
+1, looks good.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch, 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-466:
----------------------------------
Attachment: 0001-Set-tickTime-correctly-for-ZKTester.patch
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501292#comment-13501292 ]
Yixue (Andrew) Zhu commented on BOOKKEEPER-466:
-----------------------------------------------
Looks good.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch, 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-466:
----------------------------------
Attachment: 0001-Set-tickTime-correctly-for-ZKTester.patch
New patch uses DEFAULT_TICK_TIME as defined in ZooKeeperServer. It is 3000. 10000 would have been way too high.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch, 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501888#comment-13501888 ]
Hudson commented on BOOKKEEPER-466:
-----------------------------------
Integrated in bookkeeper-trunk #809 (See [https://builds.apache.org/job/bookkeeper-trunk/809/])
BOOKKEEPER-466: ZooKeeper test utility sets the port number as the tickTime (ivank) (Revision 1412061)
Result = SUCCESS
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch, 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500247#comment-13500247 ]
Flavio Junqueira commented on BOOKKEEPER-466:
---------------------------------------------
In this case, what do you think of setting it to zero to make it clear that we are really going for the minimum, 2*tickTime?
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500941#comment-13500941 ]
Ivan Kelly commented on BOOKKEEPER-466:
---------------------------------------
Im reluctant to set to 0, as a 0 tickTime makes no sense. If tickTime is 0, how many ticks happen per second? My guess is that zookeeper will fall over with this. I don't think we ever set sessionTimeout less than 3000. In any case, the real fix here is just not to use the port number as the tickTime which is very unpredictable.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500194#comment-13500194 ]
Ivan Kelly commented on BOOKKEEPER-466:
---------------------------------------
I'm setting it low, so that tests are able to choose their own session timeouts without the min timeout interfering. With 10k, min session timeout would be 20k which is too long for some tests, BookieZKExpireTest.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501099#comment-13501099 ]
Flavio Junqueira commented on BOOKKEEPER-466:
---------------------------------------------
The session timeout will the largest value between the parameter value for the zookeeper constructor or 2* tickTime. If you set the construction parameter to 0, it will be necessarily 2*tickTime.
Check it here: http://zookeeper.apache.org/doc/r3.4.5/zookeeperProgrammers.html
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-466) ZooKeeper test utility sets the
port number as the tickTime
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501127#comment-13501127 ]
Flavio Junqueira commented on BOOKKEEPER-466:
---------------------------------------------
Ah, I haven't read your patch correctly. Is there any reason why you don't want to set to 3000? If not, then I suggest we have a larger value, like 3000 or even 10000.
> ZooKeeper test utility sets the port number as the tickTime
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-466
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-466
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-Set-tickTime-correctly-for-ZKTester.patch
>
>
> This causes issues if the zookeeper port, is very high, as the minSessionTimeout is 2*tickTime by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira