[GitHub] [druid] clintropolis commented on a change in pull request #10660: fix DruidSchema incorrectly listing tables with no segments

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10660:
URL: https://github.com/apache/druid/pull/10660#discussion_r539598169



##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -270,8 +270,15 @@ public void start() throws InterruptedException
                   // Add missing segments back to the refresh list.
                   segmentsNeedingRefresh.addAll(Sets.difference(segmentsToRefresh, refreshed));
 
+                  // remove any tables which have been completely dropped before refresh

Review comment:
       Ah, the removal of segments from the broker could also mean that a datasource is no longer global/joinable and so also could require a rebuild, so i'm not sure we can remove it anymore without rethinking/reworking some other stuff. Since there were multiple places that we add to `dataSourcesNeedingRebuild`, but only one place we add to `tables`, it seemed less room for error to do the filtering here in the only place we populate it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org