[GitHub] [airflow] kaxil commented on a change in pull request #12742: Allow using _CMD / _SECRET to set `[webserver] secret_key` config

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #12742:
URL: https://github.com/apache/airflow/pull/12742#discussion_r533660364



##########
File path: tests/core/test_configuration.py
##########
@@ -557,6 +557,23 @@ def test_command_from_env(self):
             # the environment variable's echo command
             self.assertEqual(test_cmdenv_conf.get('testcmdenv', 'notacommand'), 'OK')
 
+    def test_sensitive_config_values(self):

Review comment:
       Try removing the config from configuration.py and nothing will fail without this test :)  Without it no-one would know why _CMD is not working for sql_alchemy_conn . Hope I changed your imagination ;)
   
   This test tests that these fields are allowed to be run via _CMD or _SECRET.
   
   This PR does not add any functionality and uses existing functionality which is already covered by tests, did you check that?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org