You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/21 23:05:10 UTC

[GitHub] [beam] robertwb commented on a change in pull request #17109: [WIP] Run com2ann on Python SDK

robertwb commented on a change in pull request #17109:
URL: https://github.com/apache/beam/pull/17109#discussion_r831611807



##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -782,17 +756,15 @@ def _from_normal_time(self, value):
     """Convert signed to "lexicographically ordered unsigned"."""
     return value + _TIME_SHIFT
 
-  def encode_to_stream(self, value, out, nested):
-    # type: (IntervalWindow, create_OutputStream, bool) -> None
+  def encode_to_stream(self, value: IntervalWindow, out: create_OutputStream, nested: bool) -> None:

Review comment:
       This looks wrong...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org