You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/06/17 00:32:03 UTC
Re: Review Request 21667: Ensuring scheduler IDs are unique.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21667/#review45847
-----------------------------------------------------------
I'm curious, does Erlang handle this problem?
src/sched/sched.cpp
<https://reviews.apache.org/r/21667/#comment80847>
Should there be a '-' after "scheduler"?
- Ben Mahler
On May 20, 2014, 12:52 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21667/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 12:52 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1374
> https://issues.apache.org/jira/browse/MESOS-1374
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 3684cfe9d153cab5f4ea86094fffd814ce74baa1
>
> Diff: https://reviews.apache.org/r/21667/diff/
>
>
> Testing
> -------
>
> make check.
>
> Added os::setenv("LIBPROCESS_PORT", "4242") to src/tests/main.cpp and make check.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 21667: Ensuring scheduler IDs are unique.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On June 16, 2014, 3:32 p.m., Ben Mahler wrote:
> > I'm curious, does Erlang handle this problem?
I'm not sure. I know one of the elements of the erlang pid is an internal index into a process table, but my erlang knowledge stops there. I think the process table is per node (hence requiring the node identifier in the PID) so it may be equivalent to the OS pid. Someone with more erlang-fu will know much more.
> On June 16, 2014, 3:32 p.m., Ben Mahler wrote:
> > src/sched/sched.cpp, line 105
> > <https://reviews.apache.org/r/21667/diff/1/?file=584733#file584733line105>
> >
> > Should there be a '-' after "scheduler"?
there probably should be a separator, yes.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21667/#review45847
-----------------------------------------------------------
On June 16, 2014, 3:41 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21667/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 3:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1374
> https://issues.apache.org/jira/browse/MESOS-1374
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 6e14f1cf78b9518a04c35f856fa2358a3d72ddcf
>
> Diff: https://reviews.apache.org/r/21667/diff/
>
>
> Testing
> -------
>
> make check.
>
> Added os::setenv("LIBPROCESS_PORT", "4242") to src/tests/main.cpp and make check.
>
>
> Thanks,
>
> Dominic Hamon
>
>