You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/21 01:56:36 UTC

[GitHub] [airflow] zhongjiajie commented on a change in pull request #9896: Simplify pull request template

zhongjiajie commented on a change in pull request #9896:
URL: https://github.com/apache/airflow/pull/9896#discussion_r457789954



##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1,15 +1,20 @@
----
-Make sure to mark the boxes below before creating PR: [x]
+<!--
+Thank you for contributing! Please make sure that your code changes
+are covered with tests. And in case of new features or big changes
+remember to adjust the documentation.
+
+Feel free to ping committers for the review!
 
-- [ ] Description above provides context of the change
-- [ ] Unit tests coverage for changes (not needed for documentation changes)
-- [ ] Target Github ISSUE in description if exists
-- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
-- [ ] Relevant documentation is updated including usage instructions.
-- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
+In case of existing issue, reference it using one of the following:
+
+closes: #ISSUE
+related: #ISSUE

Review comment:
       Maybe someone change the comment directly, in this case can't target to issue, how could we avoid it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org