You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/01 19:06:09 UTC

[GitHub] [arrow] westonpace commented on a change in pull request #10632: ARROW-13223: [C++] Fix Thread Sanitizer test failures

westonpace commented on a change in pull request #10632:
URL: https://github.com/apache/arrow/pull/10632#discussion_r662529376



##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -1338,11 +1342,34 @@ class BackgroundGenerator {
       return next;
     }
 
+#if (defined(__GNUC__) || defined(__clang__))
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wclass-memaccess"
+#endif
+
+    void SetWorkerThreadId(const std::thread::id tid) {

Review comment:
       If this neat trick to turn a `thread::id` into an `int64_t` is indeed reliable it might be nice to add `int64_t arrow::internal::GetCurrentThreadId()`.  Probably in `thread_pool.h/cc`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org