[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2525: HDDS-5607. remove container manager v1 code

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2525:
URL: https://github.com/apache/ozone/pull/2525#discussion_r705208725



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManagerIntegration.java
##########
@@ -102,7 +100,7 @@ public void testAllocateContainer() throws IOException {
             SCMTestUtils.getReplicationFactor(conf), OzoneConsts.OZONE);
     ContainerInfo info = containerManager
         .getMatchingContainer(OzoneConsts.GB * 3, OzoneConsts.OZONE,
-            container1.getPipeline());
+            container1.getPipeline(), excludedContainerIDS);

Review comment:
       We still have older method with out needing to pass excludedContainerIDS right?

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineUtils.java
##########
@@ -99,24 +99,6 @@ static void destroyPipeline(DatanodeDetails dn, PipelineID pipelineID,
     }
   }
 
-  /**
-   * Return the list of pipelines who share the same set of datanodes
-   * with the input pipeline.
-   *
-   * @param stateManager PipelineStateManager
-   * @param pipeline input pipeline
-   * @return list of matched pipeline
-   */
-  static List<Pipeline> checkPipelineContainSameDatanodes(
-      PipelineStateManager stateManager, Pipeline pipeline) {

Review comment:
       Is this not required?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org